Types improvements

[Viicos]

No description provided.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a613867) to head (d848a50).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #227   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          507       507           
  Branches        96        96           
=========================================
  Hits           507       507           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hukkin]

Hey there!

I don't want to actively break Python 3.7 yet, or deviate from cpython/tomllib for little benefit, so closing this.

[Viicos]

Hi @hukkin,

The minimum Python version is set in the metadata:

tomli/pyproject.toml

Line 13 in 4e245a4

requires-python = ">=3.8"

Meaning the library can't possibly be installed on 3.7.

[Viicos]

Regarding the deviation from the stdlib, understandable, I can also open a PR to cpython to parametrize the patterns?

[hukkin]

Meaning the library can't possibly be installed on 3.7.

Someone could theoretically package it for a distro despite the metadata, change the metadata themselves and test that 3.7 still works, or whatever. The main purpose of this repo currently is to be a backport of tomllib, so perhaps it makes sense to be extra conservative.

Regarding the deviation from the stdlib, understandable, I can also open a PR to cpython to parametrize the patterns?

I assume cpython may not appreciate such a PR since it doesn't run mypy against tomllib, the type annotations are there only because they were inherited from here. Might be best to avoid the busywork. Especially since they annotate private API, and are not incorrect, simply not as narrow as they could be.

[encukou]

I assume cpython may not appreciate such a PR since it doesn't run mypy against tomllib

That is indeed the case, though it might change in the future. (It's not straightforward politically, but also technically since type-checkers ignore stdlib's annotations and use typeshed instead.)

[Viicos]

That is indeed the case, though it might change in the future. (It's not straightforward politically, but also technically since type-checkers ignore stdlib's annotations and use typeshed instead.)

Was about to say that as well. pyright can't resolve the tomllib._re module, although it works through Pylance for some reason:

Anyway, happy to revisit in the future.