Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STUDENT NOTEBOOKS] docs: module two #185

Open
wants to merge 2 commits into
base: december-2024
Choose a base branch
from

Conversation

GangGreenTemperTatum
Copy link
Contributor

@GangGreenTemperTatum GangGreenTemperTatum commented Jan 18, 2025

December 2024 Student Submission

Module Completed

  • Module 1: Instruction Tuning
  • Module 2: Preference Alignment
  • Module 3: Parameter-efficient Fine-tuning
  • Module 4: Evaluation
  • Module 5: Vision-language Models
  • Module 6: Synthetic Datasets
  • Module 7: Inference
  • Module 8: Deployment

Changes Made

Describe what you've done in this PR:

  1. What concepts did you learn?
  2. What changes or additions did you make?
  3. Any challenges you faced?

Notebooks Added/Modified

List any notebooks you've added or modified:

  • Added new example in module_name/student_examples/my_example.ipynb
  • Modified existing notebook with additional examples
  • Added documentation or comments

Checklist

  • I have read the module materials
  • My code runs without errors
  • I have pushed models and datasets to the huggingface hub
  • My PR is based on the december-2024 branch

Questions or Discussion Points

Add any questions you have or points you'd like to discuss:

  1. i continuously seem to be running into memory issues after random epochs, would appreciate some help if possible!
**System Information:**
      Model Identifier: Mac15,7
      Memory: 36 GB
macOS Version: 15.2
Kernel Version: 24.2.0

**GPU Information:**
      Chipset Model: Apple M3 Pro

**Storage Details:**
   Container Free Space:      647.2 GB (647151251456 Bytes) (exactly 1263967288 512-Byte-Units)

Additional Notes

NA

@GangGreenTemperTatum GangGreenTemperTatum changed the title docs: module two dpo notebook [STUDENT NOTEBOOKS] docs: module two dpo notebook Jan 18, 2025
@GangGreenTemperTatum GangGreenTemperTatum changed the title [STUDENT NOTEBOOKS] docs: module two dpo notebook [STUDENT NOTEBOOKS] docs: module two Jan 18, 2025
@ash-01xor
Copy link
Contributor

Hey @GangGreenTemperTatum , had a doubt.
Did you get to pull the changes in the main repo before working on this and raising a PR ?
Cause since i got to do that , saw way too many changes being made in the current PR which i made.

@GangGreenTemperTatum
Copy link
Contributor Author

Hey @GangGreenTemperTatum , had a doubt.
Did you get to pull the changes in the main repo before working on this and raising a PR ?
Cause since i got to do that , saw way too many changes being made in the current PR which i made.

Hey @ash-01xor , my apologies I'm not sure I follow, my PR introduces two changes for my own notebooks.
Yes, I have a fresh clone of the repo including all branches. Are you having problems? IIUC, I think you may have your own PR but not trying to merge into the december-2024 branch and is the default 'main', can you clarify?

@ash-01xor
Copy link
Contributor

Hey @GangGreenTemperTatum , had a doubt.
Did you get to pull the changes in the main repo before working on this and raising a PR ?
Cause since i got to do that , saw way too many changes being made in the current PR which i made.

Hey @ash-01xor , my apologies I'm not sure I follow, my PR introduces two changes for my own notebooks. Yes, I have a fresh clone of the repo including all branches. Are you having problems? IIUC, I think you may have your own PR but not trying to merge into the december-2024 branch and is the default 'main', can you clarify?

Well, I meant that when I created a PR, I saw way too many changes being made. Cause I used my main branch and tried to merge it into the december-2024 branch.

However i think i understand the mistake i made now. I didn't pull from the december-2024 branch and worked , rather i made the mistake of pulling from the main branch and then worked which led to all these errors.

@GangGreenTemperTatum
Copy link
Contributor Author

Hey @GangGreenTemperTatum , had a doubt.
Did you get to pull the changes in the main repo before working on this and raising a PR ?
Cause since i got to do that , saw way too many changes being made in the current PR which i made.

Hey @ash-01xor , my apologies I'm not sure I follow, my PR introduces two changes for my own notebooks. Yes, I have a fresh clone of the repo including all branches. Are you having problems? IIUC, I think you may have your own PR but not trying to merge into the december-2024 branch and is the default 'main', can you clarify?

Well, I meant that when I created a PR, I saw way too many changes being made. Cause I used my main branch and tried to merge it into the december-2024 branch.

However i think i understand the mistake i made now. I didn't pull from the december-2024 branch and worked , rather i made the mistake of pulling from the main branch and then worked which led to all these errors.

glad you hopefully got it ironed out! if it helps, here's the process:

  1. fork the repo including all branches (uncheck default)
  2. open your IDE and change to the december-2024 branch
  3. create your branch off this branch - ie git checkout -b student/ads-awesome-branch
  4. add and commit your changes then push - ie git push -u origin student/ads-awesome-branch
  5. when you open the pull request in github, ensure to be merging your branch into december-2024:
image

hope this helps! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants