Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUBMISSION] December 2024 - Module 1,2 #168

Open
wants to merge 10 commits into
base: december-2024
Choose a base branch
from

Conversation

mcdaqc
Copy link
Contributor

@mcdaqc mcdaqc commented Jan 9, 2025

December 2024 Student Submission

Module Completed

  • Module 1: Instruction Tuning
  • Module 2: Preference Alignment
  • Module 3: Parameter-efficient Fine-tuning
  • Module 4: Evaluation
  • Module 5: Vision-language Models
  • Module 6: Synthetic Datasets
  • Module 7: Inference
  • Module 8: Deployment

Changes Made

Describe what you've done in this PR:

  1. What concepts did you learn?
  2. What changes or additions did you make?
  3. Any challenges you faced?

Notebooks Added/Modified

List any notebooks you've added or modified:

  • Added new example in module_name/student_examples/my_example.ipynb
  • Modified existing notebook with additional examples
  • Added documentation or comments

Checklist

  • I have read the module materials
  • My code runs without errors
  • I have pushed models and datasets to the huggingface hub
  • My PR is based on the december-2024 branch

Questions or Discussion Points

Add any questions you have or points you'd like to discuss:
1.
2.

Additional Notes

Any other information that might be helpful for reviewers:

@mcdaqc mcdaqc changed the title December 2024 [SUBMISSION] December 2024 - Module 1,2 Jan 9, 2025
@jucanbe
Copy link

jucanbe commented Jan 22, 2025

Good job! @mcdaqc I liked that you used Wandb for the logs! As a minor suggestion, maybe next time you could write all the code comments in English so that everyone can understand it (chat_templates_example.ipynb has some comments in Spanish).

@burtenshaw The work done is good and, in my opinion, ready to be merged.

@mcdaqc mcdaqc marked this pull request as ready for review January 27, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants