-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready to merge] Add Bonus Unit 5 #537
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
First of all thank you for this excellent tutorial.
There's some small I changes I would like to see:
1️⃣ I put some recommanded changes
Mo̶v̶e̶ ̶y̶o̶u̶r̶ ̶f̶i̶l̶e̶s̶ ̶t̶o̶ ̶u̶n̶i̶t̶ ̶b̶o̶n̶u̶s̶ ̶4̶ ̶s̶i̶n̶c̶e̶ ̶t̶h̶e̶ ̶P̶P̶O̶ ̶b̶o̶n̶u̶s̶ ̶i̶s̶ ̶n̶o̶t̶ ̶r̶e̶a̶d̶y̶ ̶y̶e̶t̶ ̶a̶n̶d̶ ̶w̶e̶ ̶d̶o̶n̶'̶t̶ ̶k̶n̶o̶w̶ ̶w̶h̶e̶n̶ ̶i̶t̶ ̶w̶i̶l̶l̶ ̶b̶e̶ ̶p̶u̶b̶l̶i̶s̶h̶e̶d̶ ̶s̶o̶ ̶f̶o̶r̶ ̶n̶o̶w̶ ̶l̶e̶t̶'̶s̶ ̶a̶l̶l̶ ̶t̶h̶i̶s̶ ̶o̶n̶e̶ ̶b̶o̶n̶u̶s̶ ̶u̶n̶i̶t̶ ̶4̶.̶ -> We don't do that finally because their unit on PPO is almost ready.
I'm preparing the thumbnail and will publish it on this PR so that you can provide your feedback.
Let me know what you think of the thumbnail @Ivan-267 @edbeeching |
Looks great! |
Cool 🔥 @Ivan-267 I was thinking we can publish the unit tomorrow or monday/tuesday? What suits you best? I gave some changes requests but overall, the unit is excellent 👏 |
Thanks for your review and making the image, I've sent some additional comments over E-mail. |
Co-authored-by: Thomas Simonini <[email protected]>
Adds the inference video to the train-our-robot section.
Adds the zip file link
Removes the normalization segment to avoid confusion, as not all of the values are currently normalized in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on this @Ivan-267 and @simoninithomas , LGTM!
Hi one last update is to put the link of the zip in the course and we're good to publish 🔥 |
Hey, I added the link here:
If you'd like I could change the link to direct link, but I wasn't sure how it works with the server so the current way was the safest. The newer changes in the PR don't show up in the doc preview. |
Yes I just saw I just launch the build PR documentation to check. But your link is correct For the environmelnt repository I added a PR: https://huggingface.co/ivan267/imitation-learning-tutorial-godot-project/discussions/1 We can publish it this afternoon or any other day you prefer @Ivan-267 ? |
Thanks for adding the readme, I merged it. We can publish it today or whenever is convenient. |
Hi what we can do is to publish it this afternoon 🔥 @edbeeching What would be nice @Ivan-267 is:
If you want what we can do:
So that your profile get promoted. But again tell me if you comfortable with that or if you have another idea? |
I'm merging it thanks 🔥 |
Adds Bonus Unit 5. Imitation Learning with Godot RL Agents
TODO: