-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update simple RAG use-case to support latest LangChain syntax #32
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@@ -1,23 +1,10 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the example! It looks like there's a code cell missing at the end though. Can you check? |
Oh, shoot - yeah I dropped an extra section and forgot to remove the lead-in. Will fix. |
Will manually cherry pick the change in the interim. |
For the conflict, feel free to override with your changes. Notebook conflicts are a pain to resolve, and the conflicting change is super minor - I can redo it in a separate PR. |
Yeah the diff was odd - I readded |
LMK if that looks better |
Yes, that was the only thing added. Thanks for re-adding it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again!
Thank you! |
What does this PR do?
Switches the legacy LangChain LLMChain to use expression language, which modernizes/removes some of the parsing.
Who can review?
Feel free to tag members/contributors who may be interested in your PR.
@MKhalusova