Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated multiagent_web_assistant.ipynb to Korean #213

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

harheem
Copy link
Contributor

@harheem harheem commented Oct 5, 2024

What does this PR do?

This is PR presents the korean translation of Have several agents collaborate in a multi-agent hierarchy 🤖🤝🤖 cookbook.

Who can review?

@4N3MONE, @jeongiin @boyunJang, @ahnjj, @SeungAhSon, @jun048098, @win2dvp21

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@harheem harheem changed the title Translated ko_multiagent_web_assistant.ipynb to Korean Translated kmultiagent_web_assistant.ipynb to Korean Oct 5, 2024
@harheem harheem changed the title Translated kmultiagent_web_assistant.ipynb to Korean Translated multiagent_web_assistant.ipynb to Korean Oct 5, 2024
notebooks/ko/ko_multiagent_web_assistant.ipynb Outdated Show resolved Hide resolved
notebooks/ko/ko_multiagent_web_assistant.ipynb Outdated Show resolved Hide resolved
notebooks/ko/ko_multiagent_web_assistant.ipynb Outdated Show resolved Hide resolved
@4N3MONE
Copy link
Contributor

4N3MONE commented Oct 5, 2024

최근 핫한 분야에 대한 쿡북이라 번역되면 많은 분들이 찾아주실 것 같네요 ㅎㅎ 몇 가지 마이너한 개선 사항 찾아 리뷰 남겼습니다. 고생하셨습니다!

@merveenoyan
Copy link
Collaborator

@harheem thanks for opening this PR! if it's approved by another fellow Korean speaker we can merge 🫰🏻

Copy link
Contributor

@jeongiin jeongiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한국어로 조금 더 자연스럽도록 수정해보았습니다!
생소한 내용이었는데 리뷰하면서 배워갑니다! 👍🏻

notebooks/ko/ko_multiagent_web_assistant.ipynb Outdated Show resolved Hide resolved
@harheem harheem marked this pull request as ready for review January 2, 2025 13:59
@harheem harheem requested review from 4N3MONE and jeongiin January 2, 2025 14:14
Copy link
Contributor

@jeongiin jeongiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@ahnjj ahnjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harheem
Copy link
Contributor Author

harheem commented Jan 3, 2025

Happy New Year @merveenoyan! 🎉 This PR is ready to be merged. Could you please take a look? :)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@merveenoyan
Copy link
Collaborator

@harheem we just merged this one: #211 if you can resolve the merge conflict in toctree we can merge yours! thanks a lot and happy new year <3

@merveenoyan merveenoyan merged commit 5a30c99 into huggingface:main Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants