Text-Generation-Inference introducing Multi-Backend #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffboudier
reviewed
Jan 9, 2025
jeffboudier
reviewed
Jan 9, 2025
jeffboudier
reviewed
Jan 9, 2025
jeffboudier
reviewed
Jan 9, 2025
jeffboudier
reviewed
Jan 9, 2025
jeffboudier
reviewed
Jan 9, 2025
jeffboudier
reviewed
Jan 9, 2025
jeffboudier
reviewed
Jan 9, 2025
jeffboudier
reviewed
Jan 9, 2025
jeffboudier
reviewed
Jan 9, 2025
jeffboudier
reviewed
Jan 9, 2025
julien-c
reviewed
Jan 10, 2025
Michellehbn
reviewed
Jan 13, 2025
tengomucho
reviewed
Jan 13, 2025
Co-authored-by: Jeff Boudier <[email protected]>
Co-authored-by: Jeff Boudier <[email protected]>
Co-authored-by: Jeff Boudier <[email protected]>
Co-authored-by: Jeff Boudier <[email protected]>
Co-authored-by: Jeff Boudier <[email protected]>
Co-authored-by: Jeff Boudier <[email protected]>
Co-authored-by: Jeff Boudier <[email protected]>
Co-authored-by: Michelle Habonneau <[email protected]>
Co-authored-by: Michelle Habonneau <[email protected]>
Co-authored-by: Michelle Habonneau <[email protected]>
Co-authored-by: Michelle Habonneau <[email protected]>
Co-authored-by: Michelle Habonneau <[email protected]>
Co-authored-by: Michelle Habonneau <[email protected]>
Co-authored-by: Michelle Habonneau <[email protected]>
Co-authored-by: Michelle Habonneau <[email protected]>
Co-authored-by: Michelle Habonneau <[email protected]>
Co-authored-by: Michelle Habonneau <[email protected]>
Co-authored-by: Jeff Boudier <[email protected]>
mfuntowicz
force-pushed
the
tgi-multi-backend
branch
from
00e5a7b to
3aa00fd
Compare
jeffboudier
reviewed
Jan 13, 2025
ErikKaum
reviewed
Jan 15, 2025
|
|
||
| TGI is made of multiple components, primarily written in Rust and Python. Rust powers the HTTP and scheduling layers, and Python remains the go-to for modeling. | ||
|
|
||
| Long story short: Rust allows us to improve the overall robustness of the serving layer with static analysis and compiler-based memory safety enforcement: it brings the ability to scale to multiple cores with the same safety guarantees more easily. Leveraging Rust’s strong type system for the HTTP layer and scheduler makes it possible to avoid memory issues while maximizing the concurrency, bypassing Global Interpreter Lock (GIL) in Python-based environments. |
There was a problem hiding this comment.
just noticed this small detail when skimming the text:
"...bypassing Global Interpreter Lock (GIL) in..."
--> "...bypassing the Global Interpreter Lock (GIL) in ..."
There was a problem hiding this comment.
"the" is not actually needed here in this case because it is not referring to a definite article due to the use of "in Python-based environments"
There was a problem hiding this comment.
Ah okay, I thought the definite article would still commonly be used when talking about specific entities, like "the Mona Lisa in Paris", "The Global Interpreter Lock in Python" etc 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.