Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cdn): refactor the billing_option resource and dataSource code style #6177

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Jan 10, 2025

What this PR does / why we need it:

commit1: refactor the billing_option resource code style.
commit2: refactor the billing_option data source code style.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


 refactor the `billing_option` resource and dataSource code style

PR Checklist

  • Tests added/passed.

Resource Test

$ make testacc TEST="./huaweicloud/services/acceptance/cdn" TESTARGS="-run TestAccBillingOption_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cdn -v -run TestAccBillingOption_basic -timeout 360m -parallel 4
=== RUN   TestAccBillingOption_basic
=== PAUSE TestAccBillingOption_basic
=== CONT  TestAccBillingOption_basic
--- PASS: TestAccBillingOption_basic (15.40s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cdn       15.467s

DataSource Test

$ make testacc TEST="./huaweicloud/services/acceptance/cdn" TESTARGS="-run TestAccDataSourceBillingOption_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cdn -v -run TestAccDataSourceBillingOption_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceBillingOption_basic
=== PAUSE TestAccDataSourceBillingOption_basic
=== CONT  TestAccDataSourceBillingOption_basic
--- PASS: TestAccDataSourceBillingOption_basic (8.82s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cdn       8.862s

Test case coverage

image

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit ce488a5 into huaweicloud:master Jan 10, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants