Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cae): add new resource to manage cae environment access vpc #6175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:

Add new resource (huaweicloud_cae_vpc_egress) to manage CAE environment access to VPC.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new resource.
2. add corresponding document and acceptance test.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o cae -f TestAccVpcEgress_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/cae" -v -coverprofile="./huaweicloud/services/acceptance/cae/cae_coverage.cov" -coverpkg="./huaweicloud/services/cae" -run TestAccVpcEgress_basic -timeout 360m -parallel 10
=== RUN   TestAccVpcEgress_basic
=== PAUSE TestAccVpcEgress_basic
=== CONT  TestAccVpcEgress_basic
--- PASS: TestAccVpcEgress_basic (115.32s)
PASS
coverage: 19.8% of statements in ./huaweicloud/services/cae
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cae       115.377s        coverage: 19.8% of statements in ./huaweicloud/services/cae
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

      ab. Related resources (parent resources) not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      image

      bb. Related resources (parent resources) not found
      image

@github-actions github-actions bot added the size/L label Jan 9, 2025
@wuzhuanhong wuzhuanhong changed the title add new resource to manage cae environment access vpc feat(cae): add new resource to manage cae environment access vpc Jan 9, 2025
@WangLiNaruto
Copy link

LGTM

2 similar comments
@Alice1319
Copy link

LGTM

@dengyali0125
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants