Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cae/app): add new resource to manage applications #6156

Merged

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:
Add new resource to manage applications.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new resource support to manage applications.
2. add related document and acceptance test.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o cae -f TestAccApplication_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/cae" -v -coverprofile="./huaweicloud/services/acceptance/cae/cae_coverage.cov" -coverpkg="./huaweicloud/services/cae" -run TestAccApplication_basic -timeout 360m -parallel 10
=== RUN   TestAccApplication_basic
--- PASS: TestAccApplication_basic (467.67s)
PASS
coverage: 25.3% of statements in ./huaweicloud/services/cae
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cae       467.742s        coverage: 25.3% of statements in ./huaweicloud/services/cae
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      c80fe10052d6afcdb3c44e5114f8f5c

      ab. Related resources (parent resources) not found
      0c40fb87a96dc50be2cbea3bb6a45bb

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      02e4c418344a3eabb2b0bf95dd314ce

      bb. Related resources (parent resources) not found
      a14b2419d68ca6b32916577717c0cd1

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 force-pushed the br_cae_application_active branch from f4dcf00 to 1027e62 Compare January 13, 2025 12:38
@deer-hang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Jan 16, 2025
@github-ci-robot github-ci-robot merged commit 2460716 into huaweicloud:master Jan 16, 2025
13 checks passed
@Lance52259 Lance52259 deleted the br_cae_application_active branch January 23, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants