feat(cae/env): add new resource to manage environments #6134
+677
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This PR has been approved by: @Lance52259 |
|
This PR needs rebase. |
Lance52259
force-pushed
the
br_cae_environment_active
branch
2 times, most recently
from
f0d056a to
9613f5c
Compare
|
Lance52259
force-pushed
the
br_cae_environment_active
branch
2 times, most recently
from
9285114 to
2700823
Compare
|
Lance52259
force-pushed
the
br_cae_environment_active
branch
2 times, most recently
from
71c616f to
ffd19dc
Compare
Lance52259
force-pushed
the
br_cae_environment_active
branch
from
ffd19dc to
edcae14
Compare
deer-hang
reviewed
Jan 9, 2025
|
|
||
| Timeouts: &schema.ResourceTimeout{ | ||
| Create: schema.DefaultTimeout(20 * time.Minute), | ||
| Delete: schema.DefaultTimeout(20 * time.Minute), |
There was a problem hiding this comment.
Please add timeouts descriptions in documentation.
deer-hang
reviewed
Jan 9, 2025
| } | ||
| createResp, err := client.Request("GET", getPath, &getOpts) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error query job by its ID (%s): %s", jobId, err) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("error query job by its ID (%s): %s", jobId, err) | |
| return nil, fmt.Errorf("error querying job by its ID (%s): %s", jobId, err) |
deer-hang
reviewed
Jan 9, 2025
| return diag.Errorf("unable to find the job ID from the API response") | ||
| } | ||
| err = waitForEnvironmentJobComplete(ctx, client, epsId, jobId, d.Timeout(schema.TimeoutDelete), d.Get("max_retries").(int)) | ||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| return diag.FromErr(err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add new resource support for the environments management.
The resource supports retry when the jobs failed (during create and delete function).
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found