Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LATERAL keyword #183

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Support LATERAL keyword #183

merged 1 commit into from
Dec 3, 2024

Conversation

huandu
Copy link
Owner

@huandu huandu commented Nov 30, 2024

It fixes #181.

@huandu huandu mentioned this pull request Nov 30, 2024
Closed
@coveralls
Copy link

Coverage Status

coverage: 96.878% (+0.003%) from 96.875%
when pulling bc2ceb4 on feature/select-lateral-derived-table
into 5067ee7 on master.

therve
therve reviewed Dec 1, 2024
View reviewed changes
Copy link

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that works. Postgresql doesn't require the presence of AS but it works with it, so it probably doesn't hurt. I haven't read the full SQL99 spec to know what's the best to do here :). Thanks!

@huandu
Copy link
Owner Author

huandu commented Dec 3, 2024

The AS can somewhat make SQL more readable. It's my personal preference to add AS before every alias. 😄

@huandu huandu merged commit c4b67f5 into master Dec 3, 2024
2 checks passed
@huandu huandu deleted the feature/select-lateral-derived-table branch December 3, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therve therve therve left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for LATERAL
3 participants
@huandu @coveralls @therve