Only log socket errors if debug is enabled #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense! 👍 merged. |
|
I don't think I mentioned by the way: HTTP Toolkit Pro is totally free for all contributors to the HTTP Toolkit repos. Is that something you'd be interested in? Let me know if so, and whether you'd prefer to use the datacamp email from your commits or the gmail email on your GH profile, and I'll set up an account. |
|
That's very generous of you, yes I'm interested! Please use my personal email on my profile. Thanks! |
|
Done! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #148, I'm finding the logging of socket errors to be too noisy. Even with the proxy setup to only intercept a specific domain (via
tlsInterceptOnly), errors such asECONNRESETorEPIPEhappen frequently on other requests.Following a similar approach as suggested in #148, this PR puts the
console.login the socket error listener behindoptions.debug. These errors being somewhat expected (comment says: Clients may disconnect at this point (for all sorts of reasons)), it seems reasonable to require the debug option to be set for them to be logged.