Skip to content

Commit

Permalink
WIP: Move notarization to Electron-Builder's built-in setup
Browse files Browse the repository at this point in the history
  • Loading branch information
pimterry committed Nov 28, 2023
1 parent 814a808 commit cf063c1
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 166 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,14 @@ jobs:
- run: npm run build
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
# For Mac notarization:
APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER }}
APPLE_API_KEY: ${{ secrets.APPLE_API_KEY }}
APPLE_API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }}
# For Mac signing:
CSC_LINK: ${{ secrets.CSC_LINK }}
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
# For Windows signing:
WIN_CSC_LINK: ${{ secrets.WIN_CSC_LINK }}
WIN_CSC_KEY_PASSWORD: ${{ secrets.WIN_CSC_KEY_PASSWORD }}

Expand Down
128 changes: 0 additions & 128 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@
"icon": "src/icons/icon.icns",
"entitlements": "src/entitlements.plist",
"entitlementsInherit": "src/entitlements.plist",
"forceCodeSigning": false,
"notarize": false
"forceCodeSigning": true,
"notarize": true
},
"dmg": {
"artifactName": "HttpToolkit-${version}.dmg"
Expand Down Expand Up @@ -118,7 +118,6 @@
"appImage": {
"artifactName": "HttpToolkit-${version}.AppImage"
},
"afterSign": "./src/hooks/after-sign.js",
"publish": null
},
"dependencies": {
Expand Down Expand Up @@ -147,7 +146,6 @@
"cross-env": "^7.0.3",
"electron": "^22.3.26",
"electron-builder": "^24.9.1",
"electron-notarize": "^1.0.0",
"lodash": "^4.17.21",
"node-fetch": "^2.6.7",
"targz": "^1.0.1",
Expand Down
2 changes: 0 additions & 2 deletions src/hooks/after-sign.js

This file was deleted.

30 changes: 0 additions & 30 deletions src/notarize.ts

This file was deleted.

0 comments on commit cf063c1

Please sign in to comment.