Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Gesv to accept nil pivots and complex matrices #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jvlmdr
Copy link

@jvlmdr jvlmdr commented Jul 2, 2013

Hey, a few minor modifications:

I've let Gesv() accept a nil argument for ipiv according to the spec.
Gesv() will also now call zgesv() if the arguments are complex.
I didn't add this for other functions e.g. Gels().
The symbols cdotusub and zdotusub weren't found on OS X.
Added linux/darwin switches for cgo.
Removed dependency on atlas.
Ran gofmt.

Let me know if you'd like only a subset of these.

@hrautila
Copy link
Owner

hrautila commented Jul 5, 2013

At the moment I could do without the gofmt part. It looks like it changes all the lines. Personally I have used indentation of 4 with spaces.

@jvlmdr
Copy link
Author

jvlmdr commented Jul 5, 2013

(Thanks for the work you've done on this library!)

I can understand not wanting to have a singularity in your commit history where everything changed but nothing changed. This is the problem that gofmt is supposed to solve though!

@hrautila
Copy link
Owner

hrautila commented Jul 6, 2013

Unfortunately gofmt can be invoked with parameters :) I used following when I originally run gofmt to the libbary: gofmt -w -tabs=false -tabwidth=4 $*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants