Revert "Ignore compilation errors temporarily"

This reverts commit 86b417e.
hpi-swa · Jan 7, 2025 · 91da9f4 · 91da9f4
1 parent 0a466ea
commit 91da9f4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -218,7 +218,6 @@ jobs:
     - name: Run Cuis-Smalltalk tests on TruffleSqueak standalone
       run: |
         mx.trufflesqueak/utils.sh download-cuis-test-image
-        trufflesqueak --vm.ea --vm.esa --headless --experimental-options --smalltalk.resource-summary=true --engine.CompilationFailureAction=Silent --engine.CompilationStatistics images/Cuis6.0-????.image -s src/de.hpi.swa.trufflesqueak.test/src/de/hpi/swa/trufflesqueak/test/runCuisTests.st
-        # trufflesqueak --vm.ea --vm.esa --headless --experimental-options --smalltalk.resource-summary=true --compiler.TreatPerformanceWarningsAsErrors=call,instanceof,store,trivial --engine.CompilationFailureAction=ExitVM --engine.CompilationStatistics images/Cuis6.0-????.image -s src/de.hpi.swa.trufflesqueak.test/src/de/hpi/swa/trufflesqueak/test/runCuisTests.st
+        trufflesqueak --vm.ea --vm.esa --headless --experimental-options --smalltalk.resource-summary=true --compiler.TreatPerformanceWarningsAsErrors=call,instanceof,store,trivial --engine.CompilationFailureAction=ExitVM --engine.CompilationStatistics images/Cuis6.0-????.image -s src/de.hpi.swa.trufflesqueak.test/src/de/hpi/swa/trufflesqueak/test/runCuisTests.st
       timeout-minutes: 10
       if: ${{ matrix.os == 'ubuntu-20.04' }}
diff --git a/mx.trufflesqueak/mx_trufflesqueak.py b/mx.trufflesqueak/mx_trufflesqueak.py
@@ -84,9 +84,9 @@ def _add_unit_tests(tasks, supports_coverage):
             if _COMPILER:
                 unittest_args.extend(
                     [
-                        "-Dgraal.CompilationFailureAction=Silent",
-                        # "-Dpolyglot.compiler.TreatPerformanceWarningsAsErrors=call,instanceof,store,trivial",
-                        "-Dpolyglot.engine.CompilationFailureAction=Silent",
+                        "-Dgraal.CompilationFailureAction=ExitVM",
+                        "-Dpolyglot.compiler.TreatPerformanceWarningsAsErrors=call,instanceof,store,trivial",
+                        "-Dpolyglot.engine.CompilationFailureAction=ExitVM",
                         "-Dpolyglot.engine.CompilationStatistics=true",
                     ]
                 )