Skip to content

Commit

Permalink
refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
Haruko Schmidt committed Jul 12, 2024
1 parent fa7c4c1 commit 538d1c3
Show file tree
Hide file tree
Showing 22 changed files with 81 additions and 74 deletions.
8 changes: 4 additions & 4 deletions Squello-Core.package/SPBLabel.class/instance/asForm.st
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ asForm
collect: [:i | self color pixelValueForDepth: self formDepth].

^ Form
extent: self extent
depth: self formDepth
fromArray: array
offset: 0@0.
extent: self extent
depth: self formDepth
fromArray: array
offset: 0@0.
2 changes: 1 addition & 1 deletion Squello-Core.package/SPBLabel.class/instance/hash.st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
comparing
hash

"Answer an integer value that is related to the identity of the receiver."

^ self id hash.
4 changes: 2 additions & 2 deletions Squello-Core.package/SPBLabel.class/methodProperties.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
"newWithName:id:color:" : "FP 5/23/2024 10:08" },
"instance" : {
"=" : "jh 7/31/2022 13:05",
"asForm" : "tk 8/2/2022 23:37",
"asForm" : "Haru 7/12/2024 18:12",
"asJson" : "AH 7/7/2024 17:01",
"asMorph" : "AH 6/22/2024 15:56",
"asString" : "lo 6/5/2022 14:49",
"color" : "lo 5/16/2022 22:01",
"color:" : "lo 5/23/2022 16:52",
"extent" : "lo 8/1/2022 13:50",
"formDepth" : "lo 6/6/2022 12:20",
"hash" : "LW 7/14/2022 11:11",
"hash" : "Haru 7/12/2024 18:17",
"id" : "lo 5/16/2022 22:01",
"id:" : "tk 8/2/2022 23:45",
"isLabel" : "lo 8/1/2022 14:52",
Expand Down
2 changes: 1 addition & 1 deletion Squello-Core.package/SPBLandingPage.class/class/RecentGitHubBoards..st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
accessing
RecentGitHubBoards: anOrderedCollection
"an orderedCollection of dictionarys, every dictionary has name, url, reponame of the githubboard that it repesents"
"an orderedCollection of dictionarys, every dictionary has name, url, reponame of the githubboard that it repesents"

^ RecentGitHubBoards := anOrderedCollection.

Expand Down
3 changes: 2 additions & 1 deletion Squello-Core.package/SPBLandingPage.class/class/RecentGitHubBoards.st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
accessing
RecentGitHubBoards

RecentGitHubBoards ifNil: [RecentGitHubBoards := OrderedCollection new.].
RecentGitHubBoards
ifNil: [RecentGitHubBoards := OrderedCollection new.].
^ RecentGitHubBoards
3 changes: 2 additions & 1 deletion Squello-Core.package/SPBLandingPage.class/class/RecentLocalBoards.st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
accessing
RecentLocalBoards

RecentLocalBoards ifNil: [RecentLocalBoards := OrderedCollection new.].
RecentLocalBoards
ifNil: [RecentLocalBoards := OrderedCollection new.].
^ RecentLocalBoards
2 changes: 1 addition & 1 deletion Squello-Core.package/SPBLandingPage.class/class/changeRecentGitHubBoards..st
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
recentboards
changeRecentGitHubBoards: lastGitHubBoard

self RecentGitHubBoards removeAllSuchThat: [:each| each = lastGitHubBoard].
self RecentGitHubBoards removeAllSuchThat: [:aRecentGitHubBoard| aRecentGitHubBoard = lastGitHubBoard].
self RecentGitHubBoards addFirst: lastGitHubBoard.

(self RecentGitHubBoards size > self numberOfRecentGitHubBoards)
Expand Down
2 changes: 1 addition & 1 deletion Squello-Core.package/SPBLandingPage.class/class/changeRecentLocalBoards..st
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
recentboards
changeRecentLocalBoards: lastLocalBoard

self RecentLocalBoards removeAllSuchThat: [:each| each = lastLocalBoard].
self RecentLocalBoards removeAllSuchThat: [:aRecentLocalBoard| aRecentLocalBoard = lastLocalBoard].
self RecentLocalBoards addFirst: lastLocalBoard.

(self RecentLocalBoards size > self numberOfRecentLocalBoards)
Expand Down
2 changes: 1 addition & 1 deletion Squello-Core.package/SPBLandingPage.class/class/minExtentHorizontal.st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
toolbuilder
minExtentHorizontal

^ 500
^ 500.
2 changes: 1 addition & 1 deletion Squello-Core.package/SPBLandingPage.class/class/minExtentVertical.st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
toolbuilder
minExtentVertical

^ 200
^ 200.
4 changes: 4 additions & 0 deletions Squello-Core.package/SPBLandingPage.class/class/minHighButton.st
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
toolbuilder
minHighButton

^ 50.
17 changes: 8 additions & 9 deletions Squello-Core.package/SPBLandingPage.class/instance/buildLocalBoardCommonActionsSpecWith..st
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@ toolbuilder-manage panel
buildLocalBoardCommonActionsSpecWith: aBuilder

^ aBuilder pluggablePanelSpec new
model: self;
children: {
self buildDeleteAllLocalBoardsButtonSpecWith: self usedBuilder.
self buildNewLocalBoardButtonSpecWith: self usedBuilder
};
layout: #horizontal;
verticalResizing: #shrinkWrap;
yourself.

model: self;
children: {
self buildDeleteAllLocalBoardsButtonSpecWith: self usedBuilder.
self buildNewLocalBoardButtonSpecWith: self usedBuilder
};
layout: #horizontal;
verticalResizing: #shrinkWrap;
yourself.
2 changes: 1 addition & 1 deletion Squello-Core.package/SPBLandingPage.class/instance/buildLocalBoardPanelSpecWith.withName..st
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ buildLocalBoardPanelSpecWith: aBuilder withName: aName
model: self;
layout: #horizontal;
horizontalResizing: #rigid;
minimumHeight: (50px);
minimumHeight: (self class minHighButton px);
children: {
self buildOpenLocalBoardButtonSpecWith: aBuilder withBoardName: aName.
self buildRenameLocalBoardButtonSpecWith: aBuilder withBoardName: aName.
Expand Down
4 changes: 2 additions & 2 deletions Squello-Core.package/SPBLandingPage.class/instance/buildLocalBoardsListChildren.st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
toolbuilder-manage panel
buildLocalBoardsListChildren

^ ( SPBBoardSaver defaultSaver boards keys collect:
[:aString | self buildLocalBoardPanelSpecWith: self usedBuilder withName: aString] ) asOrderedCollection.
^ ( SPBBoardSaver defaultSaver boards keys
collect: [:aString | self buildLocalBoardPanelSpecWith: self usedBuilder withName: aString] ) asOrderedCollection.

12 changes: 6 additions & 6 deletions Squello-Core.package/SPBLandingPage.class/instance/buildLocalBoardsListSpecWith..st
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ toolbuilder-manage panel
buildLocalBoardsListSpecWith: aBuilder

^ aBuilder pluggableScrollPaneSpec new
model: self;
vScrollBarPolicy: #always;
children: self buildLocalBoardsListChildren;
layout: #vertical;
yourself.
model: self;
vScrollBarPolicy: #always;
children: self buildLocalBoardsListChildren;
layout: #vertical;
yourself.

16 changes: 8 additions & 8 deletions Squello-Core.package/SPBLandingPage.class/instance/buildMainLayoutPanelSpecWith..st
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ toolbuilder
buildMainLayoutPanelSpecWith: aBuilder

^ aBuilder pluggablePanelSpec new
model: self;
frame: (0@0 corner: 1@1);
children: {
self buildSidebarSpecWith: aBuilder.
self buildContentPanelSpecWith: aBuilder.
};
layout: #horizontal;
yourself.
model: self;
frame: (0@0 corner: 1@1);
children: {
self buildSidebarSpecWith: aBuilder.
self buildContentPanelSpecWith: aBuilder.
};
layout: #horizontal;
yourself.
4 changes: 2 additions & 2 deletions Squello-Core.package/SPBLandingPage.class/instance/buildRecentGitHubBoardsChildren.st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
toolbuilder-recent boards
buildRecentGitHubBoardsChildren

^ ( self class RecentGitHubBoards collect:
[:aDictionary | self buildRecentGitHubBoardsButtonSpecWith: self usedBuilder withBoardInfo: aDictionary] )asOrderedCollection.
^ ( self class RecentGitHubBoards
collect: [:aDictionary | self buildRecentGitHubBoardsButtonSpecWith: self usedBuilder withBoardInfo: aDictionary] )asOrderedCollection.
10 changes: 5 additions & 5 deletions Squello-Core.package/SPBLandingPage.class/instance/buildRecentGitHubBoardsSpecWith..st
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ toolbuilder-recent boards
buildRecentGitHubBoardsSpecWith: aBuilder

^ aBuilder pluggablePanelSpec new
name: #RecentGitHubBoards;
model: self;
children: self buildRecentGitHubBoardsChildren;
layout: #horizontal;
yourself.
name: #RecentGitHubBoards;
model: self;
children: self buildRecentGitHubBoardsChildren;
layout: #horizontal;
yourself.
4 changes: 2 additions & 2 deletions Squello-Core.package/SPBLandingPage.class/instance/buildRecentLocalBoardsChildren.st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
toolbuilder-recent boards
buildRecentLocalBoardsChildren

^ ( self class RecentLocalBoards collect:
[:aString | self buildRecentLocalBoardsButtonSpecWith: self usedBuilder withName: aString] ) asOrderedCollection.
^ ( self class RecentLocalBoards
collect: [:aString | self buildRecentLocalBoardsButtonSpecWith: self usedBuilder withName: aString] ) asOrderedCollection.
10 changes: 5 additions & 5 deletions Squello-Core.package/SPBLandingPage.class/instance/buildRecentLocalBoardsSpecWith..st
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ toolbuilder-recent boards
buildRecentLocalBoardsSpecWith: aBuilder

^ aBuilder pluggablePanelSpec new
name: #RecentLocalBoards;
model: self;
children: self buildRecentLocalBoardsChildren;
layout: #horizontal;
yourself.
name: #RecentLocalBoards;
model: self;
children: self buildRecentLocalBoardsChildren;
layout: #horizontal;
yourself.
7 changes: 4 additions & 3 deletions Squello-Core.package/SPBLandingPage.class/instance/contentPanelChildren.st
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
toolbuilder
contentPanelChildren

self lastSidebarPart ifNil: [^ {}].
(self contentSpecDict includesKey: self lastSidebarPart) ifTrue:
[^ (self contentSpecDict at: self lastSidebarPart) collect: [:each| each buildWith: self usedBuilder]].
self lastSidebarPart
ifNil: [^ {}].
(self contentSpecDict includesKey: self lastSidebarPart)
ifTrue: [^ (self contentSpecDict at: self lastSidebarPart) collect: [:each| each buildWith: self usedBuilder]].
^ {}.
35 changes: 18 additions & 17 deletions Squello-Core.package/SPBLandingPage.class/methodProperties.json
View file
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
{
"class" : {
"RecentGitHubBoards" : "FP 6/10/2024 15:33",
"RecentGitHubBoards:" : "FP 6/10/2024 15:29",
"RecentLocalBoards" : "FP 6/10/2024 15:33",
"RecentGitHubBoards" : "Haru 7/12/2024 18:17",
"RecentGitHubBoards:" : "Haru 7/12/2024 18:18",
"RecentLocalBoards" : "Haru 7/12/2024 18:18",
"RecentLocalBoards:" : "Haru 6/9/2024 13:42",
"changeRecentGitHubBoards:" : "FP 6/20/2024 12:16",
"changeRecentLocalBoards:" : "FP 6/20/2024 12:17",
"minExtentHorizontal" : "Haru 7/12/2024 17:40",
"minExtentVertical" : "Haru 7/12/2024 17:42",
"changeRecentGitHubBoards:" : "Haru 7/12/2024 18:23",
"changeRecentLocalBoards:" : "Haru 7/12/2024 18:23",
"minExtentHorizontal" : "Haru 7/12/2024 18:11",
"minExtentVertical" : "Haru 7/12/2024 18:11",
"minHighButton" : "Haru 7/12/2024 18:11",
"numberOfRecentGitHubBoards" : "Haru 6/8/2024 12:38",
"numberOfRecentLocalBoards" : "Haru 6/8/2024 12:37",
"open" : "Haru 6/1/2024 12:28",
Expand All @@ -17,26 +18,26 @@
"buildContentPanelSpecWith:" : "FP 6/13/2024 13:46",
"buildDeleteAllLocalBoardsButtonSpecWith:" : "FP 6/20/2024 18:23",
"buildDeleteLocalBoardButtonSpecWith:withBoardName:" : "FP 6/20/2024 18:12",
"buildLocalBoardCommonActionsSpecWith:" : "FP 6/20/2024 16:44",
"buildLocalBoardCommonActionsSpecWith:" : "Haru 7/12/2024 18:09",
"buildLocalBoardNameSpecWith:withBoardName:" : "Haru 7/7/2024 18:52",
"buildLocalBoardPanelSpecWith:withName:" : "FP 6/20/2024 18:25",
"buildLocalBoardsListChildren" : "FP 6/13/2024 11:43",
"buildLocalBoardsListSpecWith:" : "FP 6/20/2024 16:36",
"buildMainLayoutPanelSpecWith:" : "FP 6/20/2024 16:45",
"buildLocalBoardPanelSpecWith:withName:" : "Haru 7/12/2024 18:04",
"buildLocalBoardsListChildren" : "Haru 7/12/2024 18:04",
"buildLocalBoardsListSpecWith:" : "Haru 7/12/2024 18:09",
"buildMainLayoutPanelSpecWith:" : "Haru 7/12/2024 18:06",
"buildManageLocalBoardPanelSpecWith:" : "FP 6/20/2024 18:13",
"buildNewLocalBoardButtonSpecWith:" : "FP 6/20/2024 18:24",
"buildOpenButtonSpecWith:" : "FP 6/20/2024 16:46",
"buildOpenLocalBoardButtonSpecWith:withBoardName:" : "FP 6/20/2024 18:12",
"buildRecentGitHubBoardsButtonSpecWith:withBoardInfo:" : "FP 6/20/2024 16:46",
"buildRecentGitHubBoardsChildren" : "FP 6/13/2024 10:57",
"buildRecentGitHubBoardsSpecWith:" : "FP 6/20/2024 16:47",
"buildRecentGitHubBoardsChildren" : "Haru 7/12/2024 18:10",
"buildRecentGitHubBoardsSpecWith:" : "Haru 7/12/2024 18:10",
"buildRecentLocalBoardsButtonSpecWith:withName:" : "FP 6/20/2024 16:50",
"buildRecentLocalBoardsChildren" : "FP 6/13/2024 10:56",
"buildRecentLocalBoardsSpecWith:" : "FP 6/20/2024 16:47",
"buildRecentLocalBoardsChildren" : "Haru 7/12/2024 18:10",
"buildRecentLocalBoardsSpecWith:" : "Haru 7/12/2024 18:10",
"buildRenameLocalBoardButtonSpecWith:withBoardName:" : "FP 6/20/2024 18:12",
"buildSidebarSpecWith:" : "FP 6/10/2024 14:36",
"buildWith:" : "Haru 7/12/2024 17:43",
"contentPanelChildren" : "FP 6/11/2024 12:13",
"contentPanelChildren" : "Haru 7/12/2024 18:08",
"contentPanels" : "FP 6/13/2024 11:19",
"contentSpecDict" : "Haru 7/12/2024 17:56",
"deleteAllLocal" : "FP 6/20/2024 17:20",
Expand Down

0 comments on commit 538d1c3

Please sign in to comment.