BC-6221 - SHD federal states page not loading #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergatco
previously approved these changes
Jan 10, 2024
Loki-Afro
reviewed
Jan 10, 2024
controllers/users.js
Outdated
| @@ -518,7 +518,7 @@ router.get('/', function (req, res, next) { | |||
| }); | |||
| } else { | |||
| api(req) | |||
| .get('/schools/', { qs: { $limit: false } }) | |||
| .get('/schools/', { qs: { $limit: 100 } }) | |||
There was a problem hiding this comment.
this will be solved instead in BC-6231
Loki-Afro
previously approved these changes
Jan 10, 2024
|
but a more descriptive commit message than the pr title would be appreciated |
virgilchiriac
dismissed stale reviews from Loki-Afro and bergatco
via
9fd7d9a
virgilchiriac
changed the title
bergatco
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-6221
Changes
$limit: false is not supported in api requests. Therefor, it was replaced with $limit: 100api calls endpoints are case sensitive. federalstates != federalStates
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Screenshots of UI changes
Approval for review