BC-8570 - add roommembers as viewers #5473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when rolechange is disabled, the user is still added as admin (since there is otherwise no way to make him admin)
hoeppner-dataport
approved these changes
Jan 30, 2025
hoeppner-dataport
changed the title
This was referenced Feb 2, 2025
hoeppner-dataport
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable configuring the start-role for newly added room members by FEATURE-Flag
when rolechange is disabled, the user is still added as admin (since there is otherwise no way to make him admin)
Links to Tickets or other pull requests
BC-8570
hpi-schul-cloud/nuxt-client#3534
hpi-schul-cloud/e2e-system-tests#288
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.