EW-1057: Barrel Exports changes and Deep imports modified #5365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixing room date validation on create and update
|
…d the parent config added and modified
|
3 tasks
mkreuzkam-cap
requested changes
Jan 9, 2025
apps/server/src/infra/sync/strategy/tsp/tsp-legacy-migration.service.integration.spec.ts
Show resolved
Hide resolved
| @@ -4,8 +4,8 @@ import { systemFactory } from '@modules/system/testing'; | |||
| import { InternalServerErrorException } from '@nestjs/common'; | |||
| import { Test, TestingModule } from '@nestjs/testing'; | |||
| import { SystemProvisioningStrategy } from '@shared/domain/interface/system-provisioning.strategy'; | |||
| import { IservProvisioningStrategy, OidcMockProvisioningStrategy, SanisProvisioningStrategy } from '..'; | |||
There was a problem hiding this comment.
[Optional] For clarity maybe keep '../strategy'
Suggested change
| import { IservProvisioningStrategy, OidcMockProvisioningStrategy, SanisProvisioningStrategy } from '..'; | |
| import { IservProvisioningStrategy, OidcMockProvisioningStrategy, SanisProvisioningStrategy } from '../strategy'; |
apps/server/src/modules/provisioning/service/provisioning.service.spec.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the Dataport TSP code review, the TSP related code were reviewed. In this ticket the TODOs related to imports and barrel files have to be solved. The to-dos include the following:
Explicit export in barrel files (no '*' exports)
No deep module imports if possible (maybe export necassary things from modules - if you are unsure, ask Thomas or Cedric)
Delete 'src' from module imports if it is possible
Changes are done in this scope
TSP (so ungefähr):
infra/tsp-client
infra/sync
modules/provisioning/strategy/tsp
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/secure/RapidBoard.jspa?rapidView=418&projectKey=EW&view=detail&selectedIssue=EW-1057#
Changes
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.