EW-1061 Course file export with Common Cartridge #5330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SevenWaysDP
previously requested changes
Nov 12, 2024
apps/server/src/infra/files-storage-client/files-storage-client.factory.ts
Outdated
Show resolved
Hide resolved
Fshmit
approved these changes
Jan 21, 2025
|
the implementation was tested manually again after the review changes ✅ |
WahlMartin
requested changes
Jan 23, 2025
apps/server/src/infra/files-storage-client/files-storage-client.adapter.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/files-storage/controller/files-storage.controller.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/service/common-cartridge-export.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/service/common-cartridge-export.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/service/common-cartridge-export.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/service/common-cartridge-export.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/service/common-cartridge-export.service.ts
Outdated
Show resolved
Hide resolved
|
WahlMartin
approved these changes
Jan 23, 2025
HKayed
pushed a commit
that referenced
this pull request
Jan 30, 2025
* EW-1060 testing the new export via a test endpoint * EW-1060 moved linked task to lesson dto * updating esbuild and plugins for esbuild * generating files storage api client * adding files storage client factory and module infrastructure * working on export service * EW-1060 implemented new cc export service via microservice * EW-1060 resolved dependecy of the new cc mapper * EW-1060 deleted testing dto of cc export * EW-1060 created some classes instead of interfaces * Regenerate lesson api client. * EW-1060 implemented new mapping of lesson content * EW-1060 modified mapper * EW-1060 modified mapper of lesson dto * EW-1060 removed items from api property * Regenerate lesson client. * regen lesson api. * EW-1060 modified mapper of lesson content * EW-1060 edited common cartridge mapper * changing factory to adapter * adding file resource to common cartridge * trying file export for boards * EW-1060 added control options of course element * adding file export for tasks and boards * adding modules to the learn room * added logging * changing parent id * changing search id for download files * changing download mechanics * EW-1060 changed endpoint name of new export * adding logging for files storage service * EW-1060 changed export endpoint to POST * adding debug logging * adding more debug logging * removing some debug logs * changing async code execution * EW-1060 modified mapping of some cc elements * temp changes * fixing imports for a module * changing the base path * changing logging * changing logging * EW-1060 deleted the old export endpoint of cc- microservice * logging * changing logging * changing download mechanics * updating open api definitions * adding some logging * changing factory * changing logging * changing logging * adding logging * some changes * some changes * some changes * changing something * changing something * changes * changes * some changes * some changes * changes * changes * changes * changes * changes * changes * changes * changing controller * some changes * some changes * updating files storage api * some changes * adding logging * some changes * EW-1060 fixed export of cards * changing file resource manifest type * some bug fixes, probably * hopefully fixing encoding errors * changing to streams * logging * logging * some changes * changes * changes * changes * changes * changes * changes * changes * updating the cc micro service * updating dependencies for c module * naming resources * EW-1060 changed showen title of a card * changes * changing mappers * trimming file captions * removing temp folder * EW-1060 modified test of export uc * removing dead code and linting * reverting two files * adding tests * EW-1060 added some logs * changes * some changes * EW-1060 added test for cc controller * reverting some files and code cleanup * reverting file and adding unit tests * EW-1060 changed some variables name * EW-1060 added logger module to imports * adding unit tests * adding unit tests and test factories * adding unit tests * moving method into adapter * EW-1060 added tests for cc export service * fixing compile errors * adding unit tests * code refactoring * adding check and check:watch npm scripts * fixing imports * linting * skipping one test suit * skipping another test suit * removing unused test * fixing merge error * removing linter warnings : * fixing merge errors * fixing import error * fixing imports * skipping test * skipping unit test * some debugging * test logging * changing logging * logging * logging * logging * logging * di update * di update * removing debug logs * fixing unit tests * fixing linter warnings * updating sonar config * working on coverage * working on tests * Update package.json Co-authored-by: Fshmit <[email protected]> * Update apps/server/src/modules/common-cartridge/export/interfaces/common-cartridge-resource.interface.ts Co-authored-by: Fshmit <[email protected]> * Update apps/server/src/modules/common-cartridge/service/common-cartridge.mapper.ts Co-authored-by: Fshmit <[email protected]> * working on review and renaming module * updating module index.ts * working on review * fixing compile error * fixing review comments * fixing review comments * working on review comments * fixing imports * fixing compile error * updating package.json * reverting lock file * working on review comments * fixing review comments * removing comments --------- Co-authored-by: Firas Shmit <[email protected]> Co-authored-by: Maximilian Kreuzkam <[email protected]> Co-authored-by: Fshmit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expanding the course export with files. Files uploaded in tasks and cards are now included in the export.
Links to Tickets or other pull requests
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.