-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-7631 - Keyboard does not open when tapping on column or board title #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove not needed slot, remove negative margins from column title
NFriedo
added
WIP
someone is working on that
waiting for review
Someone should review this ASAP
and removed
WIP
someone is working on that
labels
Jan 22, 2025
hoeppner-dataport
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Now the keyboard opens on mobile when tapping on the column, board or card titles. Improves board interactions for mobile and desktop. Also fixes the focus indicator of column titles.
Links to Ticket and related Pull-Requests
BC-7631
Changes
Change
readonly
todisabled
inBoardAnyTitleInput.vue
because it seems like readonly does not trigger the keyboard as the input is not editable (readonly: true - can be focused but not edited).This is just a quick fix. The Board inputs should be reworked with a11y in mind anyways (inputs should not have role heading)
3 dot menu of column title is now a sibling of the input and not a child
changed cursor from pointer to default for draft chip
fixed board interactions for sensitive touch devices, before that dragging was triggered when trying to interact with columns or cards
fix focus indicator for column title
improves board interaction on desktop e.g when using a trackpad
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging