Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7631 - Keyboard does not open when tapping on column or board title #3504

Merged
merged 12 commits into from
Jan 24, 2025

Conversation

NFriedo
Copy link
Contributor

@NFriedo NFriedo commented Jan 17, 2025

Short Description

Now the keyboard opens on mobile when tapping on the column, board or card titles. Improves board interactions for mobile and desktop. Also fixes the focus indicator of column titles.

Links to Ticket and related Pull-Requests

BC-7631

Changes

  • Change readonly to disabled in BoardAnyTitleInput.vue because it seems like readonly does not trigger the keyboard as the input is not editable (readonly: true - can be focused but not edited).
    This is just a quick fix. The Board inputs should be reworked with a11y in mind anyways (inputs should not have role heading)

  • 3 dot menu of column title is now a sibling of the input and not a child

  • changed cursor from pointer to default for draft chip

  • fixed board interactions for sensitive touch devices, before that dragging was triggered when trying to interact with columns or cards

  • fix focus indicator for column title

  • improves board interaction on desktop e.g when using a trackpad

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@NFriedo NFriedo marked this pull request as ready for review January 22, 2025 16:38
@NFriedo NFriedo added WIP someone is working on that waiting for review Someone should review this ASAP and removed WIP someone is working on that labels Jan 22, 2025
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hoeppner-dataport hoeppner-dataport removed the waiting for review Someone should review this ASAP label Jan 24, 2025
@hoeppner-dataport hoeppner-dataport merged commit 057211f into main Jan 24, 2025
72 checks passed
@hoeppner-dataport hoeppner-dataport deleted the BC-7631-mobile-title-boardinputs branch January 24, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants