Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-8581 - Add Menu Actions for Room Permissions #3495

Merged
merged 68 commits into from
Jan 27, 2025
Merged

BC-8581 - Add Menu Actions for Room Permissions #3495

merged 68 commits into from
Jan 27, 2025

Conversation

muratmerdoglu-dp
Copy link
Contributor

@muratmerdoglu-dp muratmerdoglu-dp commented Jan 14, 2025 •
edited by UzaeirKhan
Loading

Short Description

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

muratmerdoglu-dp and others added 30 commits January 14, 2025 16:16
@muratmerdoglu-dp
implement visible options generic method
3a7b9bb
@muratmerdoglu-dp
chore: remove extra option
4afec96
@muratmerdoglu-dp
remove 'hidden' option
0fe1f81
@muratmerdoglu-dp
add current userId as a parameter
0b9c016
@muratmerdoglu-dp
Merge branch 'main' into bc-8581-change-role
58c91a0
@muratmerdoglu-dp
Merge remote-tracking branch 'refs/remotes/origin/bc-8581-change-role…
b5b29da 
…' into bc-8581-change-role
@muratmerdoglu-dp
remove inheritAttr definition on KebabMenu
cd7a0f1
@muratmerdoglu-dp
chore: revert back inheritAttrs option
ed3d92c
@muratmerdoglu-dp
add KebabMenu in the table row actions
17bdfd8
@muratmerdoglu-dp
add options for the visibility options
ef3e648
@muratmerdoglu-dp
add currentUserId as main parameter
42ee93b
@muratmerdoglu-dp
chore: rename method name
2846607
@muratmerdoglu-dp
chore: remove console.log in error handler
00f6943
@muratmerdoglu-dp
chore: cast currentMember as RoomMemberResponse
08b8a01
@muratmerdoglu-dp
chore: remove leftover casting
c1570e1
@muratmerdoglu-dp
chore: rename method name
1c763a3
@muratmerdoglu-dp
set visibility of row action button value false for Roomowner
39b0d85
@muratmerdoglu-dp
add onLeaveRoom method in page component
2b0e64b
@muratmerdoglu-dp
add i18n keys for leaving room action
cf92c36
@muratmerdoglu-dp
add confirmation dialog on leaving the room
cc0c9be
@muratmerdoglu-dp
Merge branch 'main' into bc-8581-change-role
1550498
@muratmerdoglu-dp
add i18n key for menu action
7411d29
@muratmerdoglu-dp
add leave-menu at RoomDetails page
b68a68b
@muratmerdoglu-dp
fix RoomMenu unit tests
6591f84
@muratmerdoglu-dp
fix RoomMembers page's unit tests
16da7c7
@muratmerdoglu-dp
add multiple user removing unit test case
3e338c5
@muratmerdoglu-dp
Merge branch 'main' into bc-8581-change-role
8462ba9
@muratmerdoglu-dp
chore: remove the same property after solving the conflicts
456bd00
@muratmerdoglu-dp
adjust 'roomRoleName' property on memberVisibleOption
8e41e3f
@muratmerdoglu-dp
Merge branch 'main' into bc-8581-change-role
be6ede0
@UzaeirKhan UzaeirKhan mentioned this pull request Jan 27, 2025
Merged
1 task
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@muratmerdoglu-dp muratmerdoglu-dp merged commit 47d5e49 into main Jan 27, 2025
70 checks passed
@muratmerdoglu-dp muratmerdoglu-dp deleted the bc-8581-change-role branch January 27, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoeppner-dataport hoeppner-dataport hoeppner-dataport approved these changes

Assignees
No one assigned
Labels
auto-extend-activation-time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muratmerdoglu-dp @hoeppner-dataport