chore: feature toggle handling

hpi-schul-cloud · Apr 12, 2024 · fc23014 · fc23014
1 parent 8e0b559
commit fc23014
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 25 deletions.
diff --git a/src/modules/data/board/BoardStore.ts b/src/modules/data/board/BoardStore.ts
@@ -38,18 +38,21 @@ export const useBoardStore = defineStore("boardStore", () => {
 		(typeof BoardActions)[keyof typeof BoardActions]
 	>["payload"];
 
-	const emit = (
-		action: PermittedStoreActions<typeof BoardActions> | any,
-		payload: AnyBoardActionPayload
-	) => {
-		if (FEATURE_SOCKET_ENABLED) return emitOnSocket(action.type, payload);
+	const emitOnSocketWrapper = (action: {
+		type: string;
+		payload: AnyBoardActionPayload;
+	}) => {
+		if (FEATURE_SOCKET_ENABLED) {
+			emitOnSocket(action.type, action.payload);
+			return true;
+		}
 	};
 
 	async function dispatch(action: PermittedStoreActions<typeof BoardActions>) {
 		handle(
 			action,
 			on(BoardActions.fetchBoard, fetchBoard),
-			on(BoardActions.createCardRequest, createCard),
+			on(BoardActions.createCardRequest, emitOnSocketWrapper ?? createCard),
 			on(BoardActions.createCardSuccess, createCardSuccess),
 			on(BoardActions.createColumn, createColumn),
 			on(BoardActions.createColumnSuccess, createColumnSuccess),
@@ -101,16 +104,15 @@ export const useBoardStore = defineStore("boardStore", () => {
 			const payload = {
 				newCard,
 				columnId: action.payload.columnId,
-				true: true,
 			};
 
 			dispatch(BoardActions.createCardSuccess(payload));
-
-			emit(action, payload);
 		} catch (error) {
-			handleError(error, {
-				404: notifyWithTemplateAndReload("notCreated", "boardCard"),
-			});
+			dispatch(
+				BoardActions.createCardFailure({
+					errorMessage: "unable to create card",
+				})
+			);
 		}
 	};
 
@@ -138,14 +140,7 @@ export const useBoardStore = defineStore("boardStore", () => {
 
 		try {
 			const newColumn: ColumnResponse = await createColumnCall(board.value.id);
-
-			const payload = {
-				type: "create-column",
-				payload: newColumn,
-			};
-
 			dispatch(BoardActions.createColumnSuccess({ newColumn }));
-			emit(payload, newColumn);
 			return newColumn;
 		} catch (error) {
 			handleError(error, {
@@ -172,7 +167,6 @@ export const useBoardStore = defineStore("boardStore", () => {
 		try {
 			await deleteCardCall(cardId);
 			dispatch(BoardActions.deleteCardSuccess({ cardId }));
-			emit(action, { cardId });
 		} catch (error) {
 			handleError(error, {
 				404: notifyWithTemplateAndReload("notDeleted", "boardCard"),
@@ -206,7 +200,6 @@ export const useBoardStore = defineStore("boardStore", () => {
 			await deleteColumnCall(columnId);
 
 			dispatch(BoardActions.deleteColumnSuccess({ columnId }));
-			emit(action, { columnId });
 		} catch (error) {
 			handleError(error, {
 				404: notifyWithTemplateAndReload("notDeleted", "boardColumn"),
@@ -315,7 +308,6 @@ export const useBoardStore = defineStore("boardStore", () => {
 
 			await moveColumnCall(columnId, board.value.id, addedIndex);
 			dispatch(BoardActions.moveColumnSuccess(action.payload));
-			emit(action, action.payload);
 		} catch (error) {
 			handleError(error, {
 				404: notifyWithTemplateAndReload("notUpdated", "boardColumn"),
@@ -356,7 +348,6 @@ export const useBoardStore = defineStore("boardStore", () => {
 			await updateColumnTitleCall(columnId, newTitle);
 
 			dispatch(BoardActions.updateColumnTitleSuccess(action.payload));
-			emit(action, action.payload);
 		} catch (error) {
 			handleError(error, {
 				404: notifyWithTemplateAndReload("notUpdated", "boardColumn"),

diff --git a/src/modules/data/board/actions/BoardStoreActions.ts b/src/modules/data/board/actions/BoardStoreActions.ts
@@ -17,7 +17,7 @@ const getColumnId = createAction(
 );
 
 const createCardRequest = createAction(
-	"create-card",
+	"create-card-request",
 	props<{ columnId: string }>()
 );
 
@@ -26,6 +26,11 @@ const createCardSuccess = createAction(
 	props<{ newCard: CardResponse; columnId: string }>()
 );
 
+const createCardFailure = createAction(
+	"create-card-failure",
+	props<{ errorMessage: string }>()
+);
+
 const createColumn = createAction("create-column", props());
 const createColumnSuccess = createAction(
 	"create-column-success",
@@ -94,9 +99,10 @@ export {
 	getColumnId,
 	createCardRequest,
 	createCardSuccess,
+	createCardFailure,
+	deleteCard,
 	createColumn,
 	createColumnSuccess,
-	deleteCard,
 	deleteCardSuccess,
 	deleteColumn,
 	deleteColumnSuccess,