add: "State of Operation", "Float voltage" and "Absorption Voltage" #1576
+57
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e" from the Solar Charger
AndreasBoehm
requested changes
Jan 23, 2025
include/solarcharger/Stats.h
Outdated
| @@ -26,6 +26,15 @@ class Stats { | |||
| // sum of today's yield of all MPPT charge controllers in Wh | |||
| virtual std::optional<float> getYieldDay() const; | |||
|
|
|||
| // state of operation from the first available controller | |||
| virtual std::optional<uint8_t> getStateOfOperation() const { return std::nullopt; }; | |||
There was a problem hiding this comment.
can we return an enum instead of a number?
include/solarcharger/Stats.h
Outdated
| @@ -26,6 +26,20 @@ class Stats { | |||
| // sum of today's yield of all MPPT charge controllers in Wh | |||
| virtual std::optional<float> getYieldDay() const; | |||
|
|
|||
| // state of operation from the first available controller | |||
| enum class StateOfOperation : uint8_t { | |||
There was a problem hiding this comment.
using victron values as the base of the enum does not match our wish to have a generic solarcharger implementation. Having all victron related enum cases is fine but the mapping from a number to the enum case should be implementation specific.
There was a problem hiding this comment.
I reduced the cases to the minimum. Actual I just need Off, Bulk, Adsorption and Float. All other states will be handled as Various.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if I did it the right way.
I want to get the "State of Operation", "Float voltage" and "Absorption Voltage" from the victron charge controller.
But I don't want to force every solar charger provider to provide these functions.
If other provider (MPPT) support these functions, then other functions like the "Surplus" or the "Batterie Guard" should also work.
At least that was the idea behind.
Any suggestions?