Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: handle stale issues and prs #1547

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

AndreasBoehm
Copy link
Member

@AndreasBoehm AndreasBoehm commented Jan 16, 2025

Example output can be found here under Run actions/stale@v9

Statistics:

Processed items: 90
├── Processed issues: 74
└── Processed PRs   : 16
New stale issues: 34
Added issues labels: 34
Added issues comments: 34
Fetched items: 90
Fetched items events: 34
Fetched items comments: 34
Operations performed: 138

Once we agree on the config i will update the stale-action within repo-maintenance.yml and mark this PR as ready.

@AndreasBoehm AndreasBoehm changed the title Improvement: mark issues as stale and close them Improvement: handle stale issues and prs Jan 16, 2025
@AndreasBoehm AndreasBoehm force-pushed the andreasboehm/chore/stale-issues branch from 01fe592 to b0a00a5 Compare January 16, 2025 13:53
@AndreasBoehm AndreasBoehm force-pushed the andreasboehm/chore/stale-issues branch 3 times, most recently from fad1b43 to f748833 Compare January 16, 2025 14:12
Copy link
Member Author

@AndreasBoehm AndreasBoehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schlimmchen Let's discuss the settings on which i commented.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@schlimmchen
Copy link
Member

Are these the steps to perform before merging this?

  1. Add one of the labels to all open issues that we think should stay open.
  2. Remove the TODOs from the YAML.
  3. Remove the "debug" setting from the YAML.

@AndreasBoehm
Copy link
Member Author

AndreasBoehm commented Jan 17, 2025

All three steps are valid but there is one more thing todo.
The first two steps are valid.
I already removed 'debug'

Remove the stale step from its current file and adjust the existing stale action here instead: https://github.com/hoylabs/OpenDTU-OnBattery/blob/development/.github/workflows/repo-maintenance.yml#L21

I only added it to the current file to be able to test it.

@AndreasBoehm AndreasBoehm force-pushed the andreasboehm/chore/stale-issues branch 2 times, most recently from 53f04f5 to 2ebdafa Compare January 21, 2025 19:32
@AndreasBoehm AndreasBoehm force-pushed the andreasboehm/chore/stale-issues branch from 2ebdafa to da88193 Compare January 21, 2025 19:32
@AndreasBoehm AndreasBoehm marked this pull request as ready for review January 21, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants