add support for doing HTTP request against instances. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmxs
reviewed
Jul 27, 2021
mhmxs
approved these changes
Jul 28, 2021
blentz
force-pushed
the
add_url_checker
branch
from
4f09f13 to
533f4d2
Compare
mhmxs
reviewed
Jan 5, 2022
| checkPort := "80" | ||
|
|
||
| if port == "" { | ||
| uri = fmt.Sprintf("http://%s%s", i.IpAddress, path) |
There was a problem hiding this comment.
Does it make sense to make protocol configurable?
|
|
||
| log.Debugf("[GET_URL] Making HTTP request to %s", uri) | ||
| client := http.Client{ | ||
| Timeout: 3 * time.Second, |
There was a problem hiding this comment.
Does it make sense to make timeout configurable?
| } | ||
|
|
||
| // GetUrl returns the result of an HTTP request to the instance | ||
| func (i Instance) GetUrl(path string, port string) RemoteResponse { |
There was a problem hiding this comment.
This name doesn't represents all the functionality defined in the function.
| log.Error("[GET_URL] Error reading response body", err) | ||
| } | ||
|
|
||
| if resp.Header.Get("Content-Type") == "application/json" { |
There was a problem hiding this comment.
Maybe json unmarshalling is out of the scope of this function
| if err != nil { | ||
| log.Infof("Error making TCP connection to %s -> %s", net.JoinHostPort(host, port), err) | ||
| } | ||
| if conn != nil { |
There was a problem hiding this comment.
if conn == nil should be a bit more goish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for doing an HTTP GET to a cloud instance using the instance's network IP.
This facilitates checking instance healthchecks and running services in order to determine whether an instance should be acted upon.
For performance reasons, there is a TCP port check leading up to the HTTP request. The HTTP request is only executed if the instance is found to be listening on the requested port.
Example use case:
"{status: "active"}"or"{status: "failed"}"