only send spot termination if there are any

hortonworks · Jun 26, 2020 · e5f0a6c · e5f0a6c
1 parent 65b5339
commit e5f0a6c
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/aws/aws.go b/aws/aws.go
@@ -282,14 +282,19 @@ func (p awsProvider) StopInstances(instances *types.InstanceContainer) []error {
 						errChan <- err
 					}
 
-					spotInstanceNames := ""
-					for _, inst := range spotInstanceIDs {
-						name := instIDNames[*inst]
-						spotInstanceNames += fmt.Sprintf("\n%s:%s", *inst, name)
-					}
-					log.Infof("[AWS] Sending request to terminate spot instances in region %s (%d): %v", region, len(spotInstanceIDs), spotInstanceNames)
-					if _, err := p.ec2Clients[region].TerminateInstances(&ec2.TerminateInstancesInput{InstanceIds: spotInstanceIDs}); err != nil {
-						errChan <- err
+					if len(spotInstanceIDs) > 0 {
+						spotInstanceNames := ""
+						for _, inst := range spotInstanceIDs {
+							name := instIDNames[*inst]
+							spotInstanceNames += fmt.Sprintf("\n%s:%s", *inst, name)
+						}
+
+						log.Infof("[AWS] Sending request to terminate spot instances in region %s (%d): %v", region, len(spotInstanceIDs), spotInstanceNames)
+						if _, err := p.ec2Clients[region].TerminateInstances(&ec2.TerminateInstancesInput{InstanceIds: spotInstanceIDs}); err != nil {
+							errChan <- err
+						}
+					} else {
+						log.Info("[AWS] There are not spot instances to terminate")
 					}
 				}
 			}