Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks #125

Merged
merged 4 commits into from
Dec 22, 2016
Merged

Hooks #125

merged 4 commits into from
Dec 22, 2016

Conversation

gr2m
Copy link
Member

@gr2m gr2m commented Dec 10, 2016

closes #124, part of #126

Pull request against camp/101 branch so we can gather changes required for hoodiehq/camp#101 and release them all at once, but still have separate pull requests for simpler review

gr2m added 4 commits December 10, 2016 07:29
BREAKING CHANGE:

The `pre:*` and `post:*` events introduced in #65 have now been removed in favor of a proper `account.hook.{before,after}` API. See https://github.com/hoodiehq/hoodie-account-client#hooks for more details.

This is not technically a breaking change as the `pre:*` and `post:*` events have not been documented, but as they are used by `@hoodie/client` we decided to make this a breaking change nevertheless
@gr2m
Copy link
Member Author

gr2m commented Dec 10, 2016

🛎 ping @hoodiehq/maintainers 👀 this pull request is ready for review

@gr2m gr2m merged commit 1ad1415 into camp/101 Dec 22, 2016
@gr2m gr2m deleted the 124/hooks branch December 22, 2016 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant