Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include profile #112

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

include profile #112

wants to merge 5 commits into from

Conversation

gr2m
Copy link
Member

@gr2m gr2m commented Jul 25, 2016

Work in Progress

  • account.fetch
  • account.signIn
  • account.signUp

closes #107

This PR includes 2 BREAKING change

@gr2m gr2m force-pushed the 107/include-profile branch from 50e1ac3 to e3355c6 Compare July 25, 2016 20:41
@gr2m gr2m force-pushed the 107/include-profile branch from e3355c6 to ab2278d Compare October 15, 2016 21:33
@gr2m
Copy link
Member Author

gr2m commented Oct 15, 2016

account.signUp does not yet send the PUT request with ?include=profile by default

gr2m added 5 commits October 25, 2016 16:24
BREAKING CHANGE:

`account.fetch()` now sends a `GET /session/account?include=profile`, before it was just `GET /session/account`
BREAKING CHANGE:

account.signIn() now has a `include` option which defaults to `account.profile`. The `include` option gets appended to `PUT /session`, so by default the sign in request is now `PUT /session?include=account.profile`, before it was just `PUT /session`
@gr2m gr2m force-pushed the 107/include-profile branch from ab2278d to 8646b93 Compare October 25, 2016 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include profile in signIn / signOut / fetch response
1 participant