Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User Session blueprint and Create method #25

Merged
merged 4 commits into from
Oct 1, 2016
Merged

Conversation

barretodaniel
Copy link
Contributor

@barretodaniel barretodaniel commented Oct 1, 2016

closes #22


## User Session [/accounts/{id}/sessions]


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what description should be put here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this maybe?

Admins can manage sessions for all user accounts

},
"data": {
id: 'session123',
account: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at other blueprints, I should probably add a type. would that be session?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it’s "relationships": {"account": .... And make sure all properties and values are wrapped in " because it's JSON

@gr2m gr2m changed the title closes #22 Add User Session blueprint and Create method Add User Session blueprint and Create method Oct 1, 2016
@gr2m gr2m self-assigned this Oct 1, 2016

## User Session [/accounts/{id}/sessions]


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this maybe?

Admins can manage sessions for all user accounts

},
"data": {
id: 'session123',
account: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

},
"data": {
id: 'session123',
account: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it’s "relationships": {"account": .... And make sure all properties and values are wrapped in " because it's JSON

@barretodaniel barretodaniel force-pushed the user-session-blueprint branch from 4e3cc2e to 0260872 Compare October 1, 2016 22:29
"username": "[email protected]"
}
},
"relationships": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping I did this one right

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gr2m gr2m merged commit 3e0709a into master Oct 1, 2016
@gr2m gr2m deleted the user-session-blueprint branch October 1, 2016 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add route for admins to create user sessions
2 participants