-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add User Session blueprint and Create method #25
Conversation
|
||
## User Session [/accounts/{id}/sessions] | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what description should be put here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this maybe?
Admins can manage sessions for all user accounts
}, | ||
"data": { | ||
id: 'session123', | ||
account: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at other blueprints, I should probably add a type. would that be session
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it’s "relationships": {"account": ...
. And make sure all properties and values are wrapped in "
because it's JSON
|
||
## User Session [/accounts/{id}/sessions] | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this maybe?
Admins can manage sessions for all user accounts
}, | ||
"data": { | ||
id: 'session123', | ||
account: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
}, | ||
"data": { | ||
id: 'session123', | ||
account: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it’s "relationships": {"account": ...
. And make sure all properties and values are wrapped in "
because it's JSON
4e3cc2e
to
0260872
Compare
"username": "[email protected]" | ||
} | ||
}, | ||
"relationships": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hoping I did this one right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
closes #22