Added binary_sensor_HassGetState and needed values in _common.yaml.

[slungs]

NB! Having trouble with some tests failing for area, but I'm not sure whats wrong. I figured I make a PR to get some guidance. Please check and request changes

[slungs]

@larsdunemark please check commit message first. Maybe bit of a bit more than I could chew, but worth a shot.

[larsdunemark]

Great job! I think there is some parts that we need to revert and maybe rethink.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[larsdunemark]

"är alla batterierna normala i köket" <- Guess we could extract (batteri|enhet)[er] to an expansion_rules and add all different versions.

[slungs]

@larsdunemark I'll check your latest comments. I have big trouble to get one specific test to pass:

Code:

  values:
    - in: "låg[t|a]"
      out: "on"
    - in: "normal[t]"
      out: "off"

The test:

tests:
  # Battery
  - sentences:
      - "är telefon-batteriet lågt?"
    intent:
      name: HassGetState
      slots:
        domain: "binary_sensor"
        device_class: "battery"
        name: "Telefon"
        state: "on"
    response: "Nej, normalt"

Output:

FAILED tests/test_language_sentences.py::test_binary_sensor_HassGetState[sv] - AssertionError: Recognition failed for 'är telefon-batteriet lågt?'
assert None is not None

Can you see why this would fail?

[larsdunemark]

@larsdunemark I'll check your latest comments. I have big trouble to get one specific test to pass:

Code:

  values:
    - in: "låg[t|a]"
      out: "on"
    - in: "normal[t]"
      out: "off"

The test:

tests:
  # Battery
  - sentences:
      - "är telefon-batteriet lågt?"
    intent:
      name: HassGetState
      slots:
        domain: "binary_sensor"
        device_class: "battery"
        name: "Telefon"
        state: "on"
    response: "Nej, normalt"

Output:

FAILED tests/test_language_sentences.py::test_binary_sensor_HassGetState[sv] - AssertionError: Recognition failed for 'är telefon-batteriet lågt?'
assert None is not None

Can you see why this would fail?

I don't think there is any sentences that would combind {entity}-batteriet.

[slungs]

@larsdunemark I'll check your latest comments. I have big trouble to get one specific test to pass:
Code:

  values:
    - in: "låg[t|a]"
      out: "on"
    - in: "normal[t]"
      out: "off"

The test:

tests:
  # Battery
  - sentences:
      - "är telefon-batteriet lågt?"
    intent:
      name: HassGetState
      slots:
        domain: "binary_sensor"
        device_class: "battery"
        name: "Telefon"
        state: "on"
    response: "Nej, normalt"

Output:

FAILED tests/test_language_sentences.py::test_binary_sensor_HassGetState[sv] - AssertionError: Recognition failed for 'är telefon-batteriet lågt?'
assert None is not None

Can you see why this would fail?

I don't think there is any sentences that would combind {entity}-batteriet.

This is the sentence I'm testing with now, if that is what you are referring to:

          - "är <name>-[batteri[et]] {bs_battery_states:state} [<i_på> <area>]"

I can't seem any logical reason for the test to fail here. I started a discussion on Discord if you would like to jump in: https://discord.com/channels/330944238910963714/1325154473219325972

[slungs]

@larsdunemark I'll close this PR and make smaller chunks instead.