Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EN] Remove "i want" as skip word #2824

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[EN] Remove "i want" as skip word #2824

wants to merge 1 commit into from
+0 −3

Conversation

tetele
Copy link
Contributor

@tetele tetele commented Jan 3, 2025

@ViViDboarder
Copy link
Contributor

I’m still not fully convinced this should be removed. I think maybe changing it to “I want to” would make more sense though.

The takeaway from that Discord thread for me is that there should be some indication when words are removed in the debug logs. This could just have easily happened with “please” or any other word or phrase used and is not unique to “I want”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdarrengriffin mrdarrengriffin Awaiting requested review from mrdarrengriffin mrdarrengriffin is a code owner

@ViViDboarder ViViDboarder Awaiting requested review from ViViDboarder ViViDboarder is a code owner

Assignees
No one assigned
Labels
cla-signed lang: en
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[en] skip word "i want" limitation when creating custom sentences
2 participants
@tetele @ViViDboarder