Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add flipped shopping sentence & missing eteins_dirty entry #2817

Merged
merged 7 commits into from
Jan 22, 2025
+25 −2
Merged

[FR] Add flipped shopping sentence & missing eteins_dirty entry #2817

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b62d4e
Add missing eteins_dirty entry
JulienDeveaux Jan 1, 2025
1462af9
Add a flip in shopping_list sentence
JulienDeveaux Jan 1, 2025
18dfc5f
Add test sentence for shopping list
JulienDeveaux Jan 1, 2025
46dc031
add fr flip todo item phrase in HassListAddItem
JulienDeveaux Jan 7, 2025
b5f6e1b
fix: fr todo list sentence test fail
JulienDeveaux Jan 7, 2025
af61835
fix: fr expected intent HassListAddItem, got HassShoppingListAddItem
JulienDeveaux Jan 7, 2025
c7abce0
Merge branch 'main' into FR-Synonymes
JulienDeveaux Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sentences/fr/_common.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ expansion_rules:

# Dirty Verbs. We have some heavy STT limitations today. We're willing to support this hack for now. Ideally this should be removed once we have a better STT engine. Hence the fact that we decided to put it on a different expansion rules. The goal of this expansion rule is to be removed in the future.
# Éteins
eteins_dirty: "(étant|étends|étend|étendre|état|et tant|et teins|et teint|et teints|et t'as|été|étais|était)"
eteins_dirty: "(étant|etant|étends|étend|étendre|état|et tant|et teins|et teint|et teints|et t'as|été|étais|était)"
# Mets
mets_dirty: "(mais|maître)"
# ferme
Expand Down
1 change: 1 addition & 0 deletions sentences/fr/shopping_list_HassShoppingListAddItem.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ intents:
- sentences:
- ajoute [du|de la|des] <item> (dans|à) <my_list>
- met[s] [du|de la|des] <item> (dans|à) <my_list>
- ajoute (dans|à) <my_list> [du|de la|des] <item>
response: item_added
expansion_rules:
my_list: " (la|ma|notre) liste [(de|d')] [(achat[s]|course[s]|shopping)]"
Expand Down
1 change: 1 addition & 0 deletions tests/fr/shopping_list_HassShoppingListAddItem.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ tests:
- sentences:
- ajoute des pommes à la liste de courses
- mets des pommes dans la liste
- ajoute à la liste de courses des pommes
intent:
name: HassShoppingListAddItem
slots:
Expand Down