Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Set temperature with area context #2810

Merged

Conversation

galaad
Copy link
Contributor

@galaad galaad commented Dec 30, 2024

Split sentences due to following limitation see here and add area context.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @galaad

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 30, 2024 21:34
@galaad galaad marked this pull request as ready for review December 30, 2024 21:37
@andreasbrett andreasbrett changed the title Set temperature with area context [FR] Set temperature with area context Jan 1, 2025
Copy link
Contributor

@jlpouffier jlpouffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes, however please be aware that HassClimateSetTemperature is an intent that does not yet exists.

So the sentences are there, we (Language leaders and contributors) are getting ready to support it, but it's not possible to set a temperature by voice for now.

However, the changes are approved!

Thx

@jlpouffier jlpouffier merged commit 59e5aa0 into home-assistant:main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants