Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] Add expansion for smart apostrophes #2784

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ViViDboarder
Copy link
Contributor

Maybe this should be in hassil, but for now this will help with matching when users type on their phones.

Maybe this should be in hassil, but for now this will help with matching
when users type on their phones.
@andreasbrett
Copy link
Contributor

That should definitely be resolved upstream in hassil.

@ViViDboarder
Copy link
Contributor Author

Yea, I agree, but I never really got clear answers there. I was thinking about doing some normalization, but that could also have unintended consequences if not done properly. For example, we can’t just normalize input text, but also need to normalize all slot values too.

Some form of edit distance sorting and fuzzy matching would also alleviate the problem, but that’s even more complex.

I figured this could be a short term patch until a decision is made and hassil is patched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants