Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[En] remove the from <light> #2728

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ViViDboarder
Copy link
Contributor

This doesn't always make sense in a sentence to allow the to prefix. It's not
that big of a deal, however once adding <the> in, it does increase the number
of matching sentences by even more. This patch can be considered an optimization
rather than a quality improvement.

Based on top of #2727

Copy link
Contributor

@tetele tetele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review all combinations of <all> [<the>], as they could match all the the, which is unwanted.

sentences/en/light_HassTurnOff.yaml Outdated Show resolved Hide resolved
sentences/en/light_HassTurnOff.yaml Outdated Show resolved Hide resolved
sentences/en/light_HassLightSet.yaml Outdated Show resolved Hide resolved
@ViViDboarder ViViDboarder force-pushed the en-remove-the-from-light branch 3 times, most recently from 962a689 to 114e41a Compare December 23, 2024 17:28
@ViViDboarder ViViDboarder marked this pull request as ready for review December 23, 2024 17:30
This doesn't always make sense in a sentence to allow `the` to prefix. It's not
that big of a deal, however once adding `<the>` in, it does increase the number
of matching sentences by even more. This patch can be considered an optimization
rather than a quality improvement.
Copy link
Contributor

@tetele tetele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, but LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants