-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[En] remove the
from <light>
#2728
Open
ViViDboarder
wants to merge
2
commits into
home-assistant:main
Choose a base branch
from
ViViDboarder:en-remove-the-from-light
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[En] remove the
from <light>
#2728
ViViDboarder
wants to merge
2
commits into
home-assistant:main
from
ViViDboarder:en-remove-the-from-light
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetele
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review all combinations of <all> [<the>]
, as they could match all the the
, which is unwanted.
ViViDboarder
force-pushed
the
en-remove-the-from-light
branch
3 times, most recently
from
December 23, 2024 17:28
962a689
to
114e41a
Compare
This doesn't always make sense in a sentence to allow `the` to prefix. It's not that big of a deal, however once adding `<the>` in, it does increase the number of matching sentences by even more. This patch can be considered an optimization rather than a quality improvement.
ViViDboarder
force-pushed
the
en-remove-the-from-light
branch
from
December 23, 2024 17:34
114e41a
to
36a8158
Compare
tetele
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase, but LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't always make sense in a sentence to allow
the
to prefix. It's notthat big of a deal, however once adding
<the>
in, it does increase the numberof matching sentences by even more. This patch can be considered an optimization
rather than a quality improvement.
Based on top of #2727