Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] Enable the use of possessives for some nouns #2727

Merged
merged 1 commit into from
Dec 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions sentences/en/_common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -364,22 +364,23 @@ lists:
wildcard: true

expansion_rules:
name: "[the] {name}"
area: "[the] {area}"
floor: "[the] {floor} [floor]"
the: "(the|my|our)"
name: "[<the>] {name}"
area: "[<the>] {area}"
floor: "[<the>] {floor} [floor]"
area_floor: "(<area>|<floor>)"
in_area_floor: "[<in>] <area_floor>"
what_is: "(what's|whats|what is|tell me) [the]"
lockable: "[(the|my)] (lock|door|window|gate|garage door|shutter)[s]"
what_is: "(what's|whats|what is|tell me) [<the>]"
lockable: "[<the>] (lock|door|window|gate|garage door|shutter)[s]"
where_is: "(where's|wheres|where is)"
which: "(which|what) [of the]"
is: "(is|are) [(there|the)]"
which: "(which|what) [of <the>]"
is: "(is|are) [(there|<the>)]"
are: "<is>"
any: "(any|some) [of the]"
any: "(any|some) [of <the>]"
are_any: "[<are>] <any>"
how_many: "how many [of the]"
how_many: "how many [of <the>]"
brightness: "{brightness}[([ ]%)| percent]"
light: "[the] (light|lights|lighting|lamp|lamps)"
light: "[<the>] (light|lights|lighting|lamp|lamps)"
turn: "(turn|switch|change|bring)"
temp: "(temp|temperature)"
temperature: "{temperature}[([ ]°[[ ]{temperature_unit}])|( degrees {temperature_unit})]"
Expand All @@ -395,11 +396,11 @@ expansion_rules:
clean: (vacuum|clean)

# Context awareness expansion rules
all: "(all [[of] the]|every [single]|each [and every])"
all: "(all [[of] <the>]|every [single]|each [and every])"
are_all: "[<are>] <all>"
home: "(home|house|apartment|flat)"
everywhere: "(everywhere|all over|[<in>] the [(entire|whole)] <home>|[<in>] <all> (room|area|floor)[s])"
here: "([in] here|[in] (this|the) (room|area|space))"
everywhere: "(everywhere|all over|[<in>] <the> [(entire|whole)] <home>|[<in>] <all> (room|area|floor)[s])"
here: "([in] here|[in] (this|<the>) (room|area|space))"

# Questions
what_is_the_class_of_name: "(<what_is> the <class> (of|in|from|(indicated|measured) by) <name> [in <area>]|<what_is> <name>['s] <class> [in <area>]|<what_is> <area> <name>['s] <class>)"
Expand Down
4 changes: 2 additions & 2 deletions sentences/en/homeassistant_HassGetCurrentDate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ intents:
HassGetCurrentDate:
data:
- sentences:
- "(<what_is>|tell me) (todays|today's|the current) date"
- "(<what_is>|tell me) the date [today]"
- "<what_is> (todays|today's|the current) date"
- "<what_is> the date [today]"
2 changes: 1 addition & 1 deletion sentences/en/homeassistant_HassGetCurrentTime.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ intents:
HassGetCurrentTime:
data:
- sentences:
- "(<what_is>|tell me) the [current] time"
- "<what_is> the [current] time"
- "what time is it [[right] now]"
2 changes: 2 additions & 0 deletions tests/en/homeassistant_HassGetState.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ tests:

- sentences:
- "how many lights are on in the kitchen?"
- "how many lights are on in my kitchen?"
intent:
name: HassGetState
slots:
Expand All @@ -132,6 +133,7 @@ tests:

- sentences:
- "how many lights are on at the first floor?"
- "how many lights are on at my first floor?"
intent:
name: HassGetState
slots:
Expand Down
1 change: 1 addition & 0 deletions tests/en/homeassistant_HassTurnOn.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ tests:
- "turn the ceiling fan on"
- "ceiling fan on"
- "activate ceiling fan"
- "turn my ceiling fan on"
intent:
name: HassTurnOn
slots:
Expand Down
Loading