Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[de] Add sentences for GetCurrentDate and GetCurrentTime #2693
base: main
Are you sure you want to change the base?
[de] Add sentences for GetCurrentDate and GetCurrentTime #2693
Changes from all commits
65cd375575b34e697da814979279d500b2cdb50c1b855eb574e8686f3ee82aac23cd0f7ae533450412639c625e7c67deb17df7d4bFile filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sounds incorrect "was ist für zeit" or "was haben wir für zeit" are even incomplete sentences, nor are they any common shorthand sentences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it is correct from a German point of view, but this is how Swiss people would say it (in high German, not Swiss dialect).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least "was haben wir für EINE zeit" might be ok, but still "was ist für eine zeit" sounds wrong
@andreasbrett what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I certainly can't speak from a swiss POV, I am unsure if "Schweizer Hochdeutsch" should be included in
deor rather inde-CH. I think adding "Schweizer Hochdeutsch" todewould induce a lot of new sentences that in the long run would IMHO require being outsourced to a discrete language (I know, I'm very finicky with this).From what I could gather Schweizer Hochdeutsch is mostly used in writing. Also my experience in communication with Swiss people so far has been that they would talk Schweizerdeutsch unless they had to switch to Schweizer Hochdeutsch so I could understand them. But again this is very very anecdotic. So I'm not sure if adding Schweizer Hochdeutsch brings that much value.
From those both options though to me "was haben wir für EINE zeit" sounds more reasonable and could potentially also be used by german speakers. "was ist für eine zeit" sounds very dialectic to me - but again, not much experience with Schweizer Hochdeutsch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://de.wikipedia.org/wiki/Schweizer_Hochdeutsch#M%C3%BCndliche_Verwendung
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically agree, that most Swiss would prefer speaking dialect before speaking high german. For me the issue popped up, as for "Schweizerdeutsch" there is not (yet?) a STT available in HA. Everything is transcribed to "Hochdeutsch" (not sure, which variant, but I would assume "de_de"). So despite the availability of the sentences in Swiss dialect, "Schweizerdeutsch" cannot be used in HA over STT. I therefore tried out the German setting and apparently talked Swiss high german. This is how I noticed that some (for me common) sentences are not available.
I appreciate that the use case might not be huge. On the other hand, I would not expect a material delay due to the additions. And it would at least enable the usage of STT for (german speaking) Swiss users.
Regarding the distinction of "de" and "de_CH", please note that in HA "de_CH" is used for dialect (as published here, unfortunately in the configuration dialog "de_CH" is translated as "Schweizer Hochdeutsch"). "Schweizer Hochdeutsch" has much more common with "Hochdeutsch" than with "Schweizerdeutsch". So if we could integrate "Schweizer Hochdeutsch" somewhere, it would make more sense in "de". I would regret if this should not be possible, but have to leave this up to you.
Regarding the sentences: I would never say "was ist für eine zeit", but "was ist für zeit". For me "Zeit" is not countable, you cannot have one or two times. Of course this might be different in Germany (perhaps also depending on the region). But if you would only add it with "eine", then perhaps better leave it at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh what a mess. The HA Cloud TTS models for
Schweizer Hochdeutsch(=Deutsch (Schweiz)in the underlying Azure speech services) are mixed as well.The STT on the other hand transcribes (as you mentioned) to German Hochdeutsch:
https://azure.microsoft.com/de-de/updates?id=release-of-swiss-german-dialect-speech-to-text
I don't know how this could be circumvented, as we'd want to have Schweizerdeutsch sentences to match against both text and audio pipelines but as of now both pipelines provide different languages. Back to the original question: I think this is a rather foundational problem that needs solving and is far beyond the initial question regarding "was ist für zeit". Maybe time to make this a thread in the language leader board.