Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of enphase_envoy get_firmware, get_last_data, get_current_data and post_data actions #36740

Draft
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

catsmanac
Copy link
Contributor

@catsmanac catsmanac commented Jan 5, 2025

Proposed change

Enphase Envoy integrations gets 4 services/actions added:

  • enphase_envoy.get_firmwrae
  • enphase_envoy.get_last_data
  • enphase_envoy.get_current_data
  • enphase_envoy.post_data

This PR documents the new actions/services.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features
    • Enhanced Enphase Envoy integration documentation
    • Added four new actions for retrieving and managing Envoy device data:
      • Get firmware version
      • Retrieve last collected data
      • Access current data from Envoy endpoints
      • Post JSON data to Envoy device

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Jan 5, 2025
@home-assistant
Copy link

home-assistant bot commented Jan 5, 2025

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

Copy link

netlify bot commented Jan 5, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit dc62ef9
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/677addda2ae2fb000896ccee
😎 Deploy Preview https://deploy-preview-36740--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 5, 2025

📝 Walkthrough

Walkthrough

The pull request updates the Enphase Envoy integration documentation by introducing four new actions: get_firmware, get_last_data, get_current_data, and post_data. These actions provide enhanced functionality for interacting with Enphase Envoy devices, allowing users to retrieve firmware versions, access cached and current data, and send JSON data to the device. The documentation includes detailed descriptions and example YAML configurations for each new action.

Changes

File Change Summary
source/_integrations/enphase_envoy.markdown Added documentation for 4 new actions:
- enphase_envoy.get_firmware: Retrieve firmware versions
- enphase_envoy.get_last_data: Access most recent cached data
- enphase_envoy.get_current_data: Read data from Envoy endpoints
- enphase_envoy.post_data: Send JSON data to Envoy

Sequence Diagram

sequenceDiagram
    participant User
    participant HomeAssistant
    participant EnphaseEnvoy

    User->>HomeAssistant: Request firmware version
    HomeAssistant->>EnphaseEnvoy: Get firmware
    EnphaseEnvoy-->>HomeAssistant: Return firmware versions
    HomeAssistant-->>User: Display firmware info

    User->>HomeAssistant: Request current data
    HomeAssistant->>EnphaseEnvoy: Get current data
    EnphaseEnvoy-->>HomeAssistant: Return device data
    HomeAssistant-->>User: Display device data
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
source/_integrations/enphase_envoy.markdown (5)

194-202: Fix formatting in the actions list

Remove the extra space after the colon.

-Available actions are:
-
+Available actions are:
🧰 Tools
🪛 LanguageTool

[uncategorized] ~196-~196: Loose punctuation mark.
Context: ...ailable actions are: - switch.turn_on, switch.turn_off, switch.toggle - [`...

(UNLIKELY_OPENING_PUNCTUATION)


348-348: Fix grammatical error in note

Replace "then" with "than" in the comparison.

-Do not schedule or execute it at intervals less then the default collection time of 1 minute.
+Do not schedule or execute it at intervals less than the default collection time of 1 minute.
🧰 Tools
🪛 LanguageTool

[grammar] ~348-~348: Comparison requires “than”, not ‘then’ nor ‘as’.
Context: ...chedule or execute it at intervals less then the default collection time of 1 minute...

(COMP_THAN)


493-493: Fix grammatical errors in the description

There are two grammar issues to fix:

  1. Add a comma before "however"
  2. Use correct past participle "sent" instead of "send"
-This action however, has the endpoint as required, no *give me all data* option. Also, a GET request is send to the envoy for each action call.
+This action, however, has the endpoint as required, no *give me all data* option. Also, a GET request is sent to the envoy for each action call.
🧰 Tools
🪛 LanguageTool

[formatting] ~493-~493: Consider inserting a comma before ‘however’.
Context: ...xes to select data to be returned. This action however, has the endpoint as required, no *give ...

(HOWEVER_MISSING_COMMA)


[grammar] ~493-~493: Consider using either the past participle “sent” or the present participle “sending” here.
Context: ...ll data* option. Also, a GET request is send to the envoy for each action call. In ...

(BEEN_PART_AGREEMENT)


498-498: Fix grammatical error in note

Replace "then" with "than" in the comparison.

-Be careful with scheduling it at intervals less then the default collection time of 1 minute.
+Be careful with scheduling it at intervals less than the default collection time of 1 minute.
🧰 Tools
🪛 LanguageTool

[grammar] ~498-~498: Comparison requires “than”, not ‘then’ nor ‘as’.
Context: ...ul with scheduling it at intervals less then the default collection time of 1 minute...

(COMP_THAN)


507-508: Fix JSON terminology and grammar

There are several issues to address:

  1. Correct the spelling of "JSON"
  2. Fix the grammar of "is send"
-This action allows sending data to the envoy. Data must be a JSON string that can pass the json.loads method. The jason data is send to the specified endpoint on the envoy.
+This action allows sending data to the envoy. Data must be a JSON string that can pass the JSON.loads method. The JSON data is sent to the specified endpoint on the envoy.
🧰 Tools
🪛 LanguageTool

[grammar] ~507-~507: Consider using either the past participle “sent” or the present participle “sending” here.
Context: ...he json.loads method. The jason data is send to the specified endpoint on the envoy....

(BEEN_PART_AGREEMENT)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29d08bd and c2b808f.

⛔ Files ignored due to path filters (1)
  • source/images/integrations/enphase_envoy/enphase_envoy_action_getfirmware_dev_ui.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • source/_integrations/enphase_envoy.markdown (2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/enphase_envoy.markdown

[uncategorized] ~196-~196: Loose punctuation mark.
Context: ...ailable actions are: - switch.turn_on, switch.turn_off, switch.toggle - [`...

(UNLIKELY_OPENING_PUNCTUATION)


[grammar] ~348-~348: Comparison requires “than”, not ‘then’ nor ‘as’.
Context: ...chedule or execute it at intervals less then the default collection time of 1 minute...

(COMP_THAN)


[grammar] ~461-~461: This noun normally spelled as one word.
Context: ...dpoints are accessible using an Enphase Home Owner account. | Data attribute | Optional |...

(OWNER_COMPOUNDS)


[formatting] ~493-~493: Consider inserting a comma before ‘however’.
Context: ...xes to select data to be returned. This action however, has the endpoint as required, no *give ...

(HOWEVER_MISSING_COMMA)


[grammar] ~493-~493: Consider using either the past participle “sent” or the present participle “sending” here.
Context: ...ll data* option. Also, a GET request is send to the envoy for each action call. In ...

(BEEN_PART_AGREEMENT)


[grammar] ~498-~498: Comparison requires “than”, not ‘then’ nor ‘as’.
Context: ...ul with scheduling it at intervals less then the default collection time of 1 minute...

(COMP_THAN)


[grammar] ~507-~507: Consider using either the past participle “sent” or the present participle “sending” here.
Context: ...he json.loads method. The jason data is send to the specified endpoint on the envoy....

(BEEN_PART_AGREEMENT)

🪛 Markdownlint (0.37.0)
source/_integrations/enphase_envoy.markdown

316-316: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


316-316: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


434-434: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


434-434: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


495-495: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


495-495: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


565-565: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


565-565: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)

🪛 GitHub Actions: home-assistant.io Test
source/_integrations/enphase_envoy.markdown

[error] 516-516: Incorrect usage of the term: "json", use "JSON" instead

🔇 Additional comments (1)
source/_integrations/enphase_envoy.markdown (1)

285-570: Documentation looks great!

The documentation for the new actions is comprehensive, well-structured, and includes clear examples and appropriate warnings. The explanations are thorough and will help users understand how to use these new features effectively.

🧰 Tools
🪛 LanguageTool

[grammar] ~348-~348: Comparison requires “than”, not ‘then’ nor ‘as’.
Context: ...chedule or execute it at intervals less then the default collection time of 1 minute...

(COMP_THAN)


[grammar] ~461-~461: This noun normally spelled as one word.
Context: ...dpoints are accessible using an Enphase Home Owner account. | Data attribute | Optional |...

(OWNER_COMPOUNDS)


[formatting] ~493-~493: Consider inserting a comma before ‘however’.
Context: ...xes to select data to be returned. This action however, has the endpoint as required, no *give ...

(HOWEVER_MISSING_COMMA)


[grammar] ~493-~493: Consider using either the past participle “sent” or the present participle “sending” here.
Context: ...ll data* option. Also, a GET request is send to the envoy for each action call. In ...

(BEEN_PART_AGREEMENT)


[grammar] ~498-~498: Comparison requires “than”, not ‘then’ nor ‘as’.
Context: ...ul with scheduling it at intervals less then the default collection time of 1 minute...

(COMP_THAN)


[grammar] ~507-~507: Consider using either the past participle “sent” or the present participle “sending” here.
Context: ...he json.loads method. The jason data is send to the specified endpoint on the envoy....

(BEEN_PART_AGREEMENT)

🪛 Markdownlint (0.37.0)

316-316: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


316-316: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


434-434: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


434-434: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


495-495: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


495-495: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


565-565: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)


565-565: Expected: asterisk; Actual: underscore
Emphasis style

(MD049, emphasis-style)

🪛 GitHub Actions: home-assistant.io Test

[error] 516-516: Incorrect usage of the term: "json", use "JSON" instead

@catsmanac catsmanac marked this pull request as draft January 5, 2025 18:07
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant