-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document zabbix include_strings config #36734
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request introduces a new configuration option Changes
Sequence DiagramsequenceDiagram
participant User
participant Zabbix Integration
User->>Zabbix Integration: Configure with include_strings
alt include_strings is true
Zabbix Integration->>Zabbix Integration: Publish string states
else include_strings is false (default)
Zabbix Integration->>Zabbix Integration: Skip string states
end
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/zabbix.markdown (2)
65-69
: Enhance documentation clarity for theinclude_strings
option.While the documentation follows the correct format, it could be more helpful by:
- Clarifying what happens to string states when
include_strings
is false (are they ignored, filtered out, etc?)- Adding an example configuration showing its usage
Consider adding this example to the "Full configuration" section:
zabbix: host: ZABBIX_HOST path: ZABBIX_PATH ssl: false username: USERNAME password: PASSWORD publish_states_host: homeassistant + include_strings: true exclude: domains: - device_tracker
65-69
: Add reference to the parent PR.To help with tracking changes and providing additional context, consider adding a comment referencing the parent PR where this feature was introduced (PR 134773).
Add a small note in the description:
include_strings: description: >- Also publish string states, i.e. states which cannot be cast to a numeric value. + Introduced in Home Assistant Core PR #134773. required: false type: boolean default: false
Proposed change
This PR documents the new Zabbix config value
include_strings
introduced in PR 134773.Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
include_strings
for Zabbix integration.