Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide steps for Tesla Fleet API 2025 update. #36725
Provide steps for Tesla Fleet API 2025 update. #36725
Changes from 7 commits
83d2a12
8ee7275
15ebc41
b113650
98ca250
e307450
2f9acaf
68b55de
be08691
8bc4ae8
8e74868
a81f0e2
5eab1a4
a6db708
17a5a62
4bc8f59
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to cover EU here too, and the NA domain looks wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bre77 Thanks for the suggestions.
I just verified the NA domain, and it looks correct. It appears unchanged in your suggestion too. Any idea what I may be missing?
There is already a line immediately below this section mentioning:
If we're instead expanding each region-specific curl command, shall I
- also add the China URL in a similar but separate section? The Asia-Pacific URL excludes China.
- abbreviate the line referencing the Tesla docs to something like
Refer to the [Base URLs documentation](https://developer.tesla.com/docs/fleet-api/getting-started/base-urls) for more info.
, omitting the direction to replace theAUDIENCE
value?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I have made a mistake, the curl address is not region specific, I thought it was. Yes if you can condense this down to a single example that would be better, I just couldnt think of a great way to clearly communicate that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Does the single example that I've added suffice, along with the note after it to swap the
AUDIENCE
value to the correct URL (also provides links to where to find the region URLs)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
LONG_GIBBERISH_ACCESS_TOKEN_STRING
placeholder seems to have been missed during editing.