-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Policy-Based Routing switches #36656
base: next
Are you sure you want to change the base?
Conversation
…f other rule switch documentation.
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
📝 WalkthroughWalkthroughThe pull request updates the UniFi Network integration documentation, focusing on improving clarity and consistency in describing network control features. The changes involve correcting section headings, refining descriptions of port forwarding and traffic rules, and adding a new section about policy-based routing rules. The modifications aim to provide more precise information about how different network control entities are represented and identified. Changes
Sequence DiagramsequenceDiagram
participant User
participant UniFi Integration
participant Network Entities
User->>UniFi Integration: Configure Network Rules
UniFi Integration->>Network Entities: Generate Entities
Network Entities-->>User: Display Port Forwarding Rules
Network Entities-->>User: Display Traffic Rules
Network Entities-->>User: Display Policy-Based Routing Rules
The sequence diagram illustrates how the UniFi Integration generates and displays different types of network rule entities to the user, reflecting the documentation updates. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/unifi.markdown (1)
158-160
: Remove extra blank line for consistencyWhile the content is correct, there's an extra blank line between the heading and the content that isn't present in other similar sections. Consider removing it for consistency.
### Control Policy-Based Routing Rules - Entities appear for each Policy-Based Routing Rule. The switches can be identified from icon {% icon "mdi:routes" %}.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/unifi.markdown
(1 hunks)
🔇 Additional comments (3)
source/_integrations/unifi.markdown (3)
150-152
: Documentation looks good!The Port Forwarding Rules section is clear, concise, and includes the appropriate icon reference for visual identification.
154-156
: Documentation looks good!The Traffic Rules section is well-documented with clear identification of the icon used for these switches.
150-160
: Overall documentation structure is excellent!The documentation for all three types of rules (Port Forwarding, Traffic, and Policy-Based Routing) is well-organized, consistent in style, and provides clear identification through icons. This makes it easy for users to understand and identify different types of switches in their Home Assistant interface.
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Proposed change
Added documentation for Policy-Based Routing Rule switches (new feature proposed in a PR to Unifi integration).
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
The Unifi integration now includes various types of switches for enabling or disabling different types of rules. To improve clarity, I have grouped the documentation for all these switches into a single section. Additionally, I have included the icons used for each rule type in the documentation, making it easier for users to identify the relevant switches.
Checklist
current
branch.next
branch.Summary by CodeRabbit