add radioactivity_concentration to sensor.markdown #36641
Conversation
home-assistant
bot
added
has-parent
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request introduces a new device class called Changes
Sequence DiagramclassDiagram
class SensorDeviceClasses {
+ temperature
+ humidity
+ pressure
+ ...
+ radioactivity_concentration
}
This simple diagram illustrates the addition of the new Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/sensor.markdown (1)
88-88: LGTM! Consider adding a brief description for clarity.The new device class is correctly formatted and placed in alphabetical order. The specified units (Bq/m³ and pCi/L) are appropriate for measuring radioactivity concentration.
Consider adding a brief description to help users understand the purpose, similar to other entries. For example:
- **radioactivity_concentration**: Radioactivity concentration in Bq/m³ or pCi/L + **radioactivity_concentration**: Measurement of radioactive particles concentration in air or water in Bq/m³ or pCi/L
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/sensor.markdown(1 hunks)
🔇 Additional comments (1)
source/_integrations/sensor.markdown (1)
88-88: Verify integration with core changes
This documentation change appears to be related to PR #134376 in the core repository. Please ensure that:
- The units match those implemented in the core PR
- The documentation is synchronized with the core PR's timeline
✅ Verification successful
Let me verify the documentation in the linked PR to ensure consistency.
Documentation changes are properly synchronized with core changes
The documentation changes are correctly aligned with the core PR #134376:
- Both PRs are currently open and synchronized
- The units (Bq/m³ and pCi/L) match between the documentation and core implementation
- The documentation change is consistent with existing usage (e.g., in airq integration)
- The changes are properly targeted for the next release
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if the core PR exists and its status
gh pr view 134376 --repo home-assistant/core --json title,state,body
Length of output: 5158
Script:
#!/bin/bash
# Check the linked documentation PR
gh pr view 36641 --repo home-assistant/home-assistant.io --json title,state,body,files
# Search for any other mentions of radioactivity units in the docs
rg -i "radioactivity.*concentration|bq/m.*|pci/l" --type md
Length of output: 3605
Proposed change
Adding documentation for radioactivity_concentration device class that parallels the codebase pr
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.Summary by CodeRabbit