Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support offset on input_datetime time trigger #23855

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

karwosts
Copy link
Contributor

Proposed change

Show offset field for input_datetime entities. For home-assistant/core#131550

Also this removes time entities from the entity selector, as they don't seem to have actually ever been supported (backend just returns an error). Seems like they were added there by mistake.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon
Copy link
Contributor

silamon commented Jan 23, 2025

That's true, it's still on my list to implement it after we found out it is missing.

@frenck frenck added the backend merged The backend PR for this frontend PR has been merged label Jan 23, 2025
@MindFreeze MindFreeze merged commit 1532093 into home-assistant:dev Jan 23, 2025
17 checks passed
@karwosts karwosts deleted the input_datetime_offset branch January 23, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend merged The backend PR for this frontend PR has been merged cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants