Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed positioning for ha-form-multi_select #23781

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Jan 18, 2025

Proposed change

Attempt to fix ha-form-multi_select used in a dialog. Apparently it's been not behaving well since it was updated from MD2 to MD3.

Changing the positioning to fixed seems to behave more like as would be expected. I cannot imagine every possible usecase of this form element, so I can't test that this works correctly in every case.

Unsure if using fixed positioning could have any drawbacks. Unsure if I should try to limit the positioning change to some subset of instances (in dialogs only?). It looks fine with this change in time-condition which is the other usecase I know of.

Current (using github integration options flow as example):

image

With fix:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@karwosts karwosts mentioned this pull request Jan 18, 2025
4 tasks
@karwosts karwosts added this to the 2025.1 milestone Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homekit dialog is cut-off
1 participant