Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve automation save dialog when leaving editor dirty #23589

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Jan 5, 2025

Proposed change

This PR improves the dialog for saving automations, to be used if the user wants to leave the editor in an dirty state. Either when creating a new automation or when editing an existing one.

I also renamed the dialog to save instead of rename, as it is now more about saving and not renaming.

Edit: Worked closely with @matthiasdebaat on Discord again on that. The design is based on his mockup.

image image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added the Needs UX Pull requests requiring a review from the Home Assistant design team label Jan 6, 2025
@jpbede jpbede force-pushed the improve-automation-save-dialog branch from fffbca0 to 69f54f5 Compare January 7, 2025 13:26
@jpbede jpbede force-pushed the improve-automation-save-dialog branch from 69f54f5 to bd7fbd4 Compare January 16, 2025 06:45
@MindFreeze MindFreeze removed the Needs UX Pull requests requiring a review from the Home Assistant design team label Jan 21, 2025
@MindFreeze MindFreeze merged commit 09102d3 into home-assistant:dev Jan 23, 2025
15 checks passed
@jpbede jpbede deleted the improve-automation-save-dialog branch January 23, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants