Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve chart zoom #23326

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Improve chart zoom #23326

merged 1 commit into from
Dec 18, 2024

Conversation

MindFreeze
Copy link
Contributor

@MindFreeze MindFreeze commented Dec 18, 2024

Proposed change

  • reduce animation speed
  • reduce scrolling zoom speed
  • add a tiny threshold to drag zooming to ignore accidental clicks
  • do a reset after a full zoom out as a temp workaround for messed up Y scale after zoom in and pan. there is an open PR to fix this in the plugin

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 8a46ef6 into dev Dec 18, 2024
16 checks passed
@bramkragten bramkragten deleted the chart-zoom-tweak branch December 18, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants