Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mastodon post action #134788

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from

Conversation

andrew-codechimp
Copy link
Contributor

@andrew-codechimp andrew-codechimp commented Jan 5, 2025

Breaking change

Deprecate the use of the legacy notify platform and introduce a new mastodon.post action which has dedicated descriptive fields rather than data elements that are only obvious by referring to the documentation.
If the old notify service is used then an issue will be raised warning that this is deprecated and will be removed in 2025.8.

Proposed change

  • Add new post action with tests, following the arch discussion on migration to the new notify platform.
  • Update IQS that exception translations are now supported (both in the new action and also the old notify since they have the same exception messages).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 5, 2025

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (mastodon) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mastodon can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mastodon Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@andrew-codechimp andrew-codechimp marked this pull request as ready for review January 5, 2025 15:57
@joostlek
Copy link
Member

joostlek commented Jan 6, 2025

So what I am wondering, will we ever use the notify entity? Because if we do, I think we should rather migrate to that at once, instead of going to a sub service first

@andrew-codechimp
Copy link
Contributor Author

andrew-codechimp commented Jan 6, 2025

I experimented with the new notify entity and followed the arch discussion, the Mastodon post will always want more than the generic but well typed notification action provides so I'd never be looking to add the new notify entity, a social post isn't really a notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants