Use elif instead of nested if

home-assistant · Mar 18, 2023 · 2d13552 · 2d13552
1 parent 5414598
commit 2d13552
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/.github/workflows/builder.yaml b/.github/workflows/builder.yaml
@@ -79,19 +79,17 @@ jobs:
       - name: Check if add-on should be built
         id: check
         run: |
-          if [[ "${{ steps.info.outputs.image }}" != "null" ]]; then
-            if [[ "${{ steps.info.outputs.architectures }}" =~ ${{ matrix.arch }} ]]; then
-                echo "build_arch=true" >> $GITHUB_OUTPUT;
-                echo "image=$(echo ${{ steps.info.outputs.image }} | cut -d'/' -f3)" >> $GITHUB_OUTPUT;
-                if [[ -z "${{ github.head_ref }}" ]] && [[ "${{ github.event_name }}" == "push" ]]; then
-                    echo "BUILD_ARGS=" >> $GITHUB_ENV;
-                fi
-              else
-                echo "${{ matrix.arch }} is not a valid arch for ${{ matrix.addon }}, skipping build";
-                echo "build_arch=false" >> $GITHUB_OUTPUT;
-            fi
+          if [[ "${{ steps.info.outputs.image }}" == "null" ]]; then
+            echo "Image property is not defined, skipping build"
+            echo "build_arch=false" >> $GITHUB_OUTPUT;
+          elif [[ "${{ steps.info.outputs.architectures }}" =~ ${{ matrix.arch }} ]]; then
+              echo "build_arch=true" >> $GITHUB_OUTPUT;
+              echo "image=$(echo ${{ steps.info.outputs.image }} | cut -d'/' -f3)" >> $GITHUB_OUTPUT;
+              if [[ -z "${{ github.head_ref }}" ]] && [[ "${{ github.event_name }}" == "push" ]]; then
+                  echo "BUILD_ARGS=" >> $GITHUB_ENV;
+              fi
             else
-              echo "Image property is not defined, skipping build"
+              echo "${{ matrix.arch }} is not a valid arch for ${{ matrix.addon }}, skipping build";
               echo "build_arch=false" >> $GITHUB_OUTPUT;
           fi